-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lazy load connectivity info #107
Open
jbutler
wants to merge
1
commit into
main
Choose a base branch
from
lazy-load-conn-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
reviewed
Aug 18, 2022
src/main/java/com/aws/greengrass/clientdevices/auth/iot/ConnectivityInfoProvider.java
Outdated
Show resolved
Hide resolved
MikeDombo
reviewed
Aug 18, 2022
src/test/java/com/aws/greengrass/clientdevices/auth/iot/ConnectivityInfoProviderTest.java
Outdated
Show resolved
Hide resolved
MikeDombo
reviewed
Aug 18, 2022
src/main/java/com/aws/greengrass/clientdevices/auth/iot/ConnectivityInfoProvider.java
Show resolved
Hide resolved
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against c63e827 |
Initial calls to getCachedConnectivityInfo() may return an empty list if it occurs before an initial call to getConnectivityInfo(). This change will ensure that getConnectivityInfo() has been called when returning cached results.
jbutler
force-pushed
the
lazy-load-conn-info
branch
from
August 18, 2022 18:24
c4616cb
to
c63e827
Compare
MikeDombo
approved these changes
Aug 18, 2022
vaibhavmurkute
approved these changes
Aug 18, 2022
MikeDombo
reviewed
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still want this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial calls to getCachedConnectivityInfo() may return an empty list if
it occurs before an initial call to getConnectivityInfo(). This change
will ensure that getConnectivityInfo() has been called when returning
cached results.
Issue #, if available:
Description of changes:
Why is this change necessary:
Disabling certificate rotation does not work as expected, as the initial certificate does not contain connectivity information. This change forces an initial load so that this config option is actually usable without needing to restart the CDA component.
How was this change tested:
Deployed CDA with above config and confirmed that connectivity info is included in the initial certificate.
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.