Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package version to maps/places/routes requests via custom user agent header #72

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

cgalvan
Copy link
Collaborator

@cgalvan cgalvan commented Jul 18, 2024

Description

Append migration adapter tag/version number to the custom user agent header for the maps/places/routes requests that come from the migration adapter. Added pre-build step to dynamically generate/consume the package version in the script.

@cgalvan cgalvan requested a review from a team as a code owner July 18, 2024 14:36
mojodna
mojodna previously approved these changes Jul 18, 2024
src/index.ts Show resolved Hide resolved
src/maps.ts Outdated Show resolved Hide resolved
jonayuan
jonayuan previously approved these changes Jul 18, 2024
Copy link
Contributor

@jonayuan jonayuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cgalvan cgalvan dismissed stale reviews from jonayuan and mojodna via a2f1ecb July 18, 2024 18:33
@cgalvan cgalvan requested review from mojodna and jonayuan July 18, 2024 18:33
@cgalvan cgalvan merged commit 09d10d5 into aws-geospatial:main Jul 18, 2024
1 check passed
@cgalvan cgalvan deleted the AddCustomUserAgent branch July 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants