Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DirectionsRendererOptions #48

Merged
merged 3 commits into from
May 30, 2024
Merged

Added DirectionsRendererOptions #48

merged 3 commits into from
May 30, 2024

Conversation

jonayuan
Copy link
Contributor

@jonayuan jonayuan commented May 29, 2024 •
edited
Loading

  • Added map, markerOptions, preserveViewport, directions, suppressMarkers, suppressPolylines options
  • Added various internal helper methods to MigrationDirectionsRenderer class
  • Created unit test file for directions file and added DirectionsRenderer tests
  • Updated InfoWindow open method to call close before opening to match Google's

@jonayuan jonayuan requested a review from a team as a code owner May 29, 2024 17:06
cgalvan
cgalvan previously approved these changes May 29, 2024
View reviewed changes
src/directions.ts Outdated Show resolved Hide resolved
neelmurt
neelmurt approved these changes May 30, 2024
View reviewed changes
src/directions.ts Show resolved Hide resolved
@jonayuan jonayuan merged commit a4d12ee into aws-geospatial:main May 30, 2024
1 check passed
@jonayuan jonayuan deleted the DirectionsRendererOptions branch June 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neelmurt neelmurt neelmurt approved these changes

@cgalvan cgalvan cgalvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonayuan @cgalvan @neelmurt