[Enhancement] [ALS-1792] Update creds and websocket implementation #235
Conversation
…ket-implementation
…te-creds-and-websocket-implementation [Enhancement] [ALS-1792] Update creds and websocket implementation
| ); | ||
| }; | ||
| const AppWrapper: FC<AppWrapperProps> = ({ children }) => ( | ||
| <ThemeProvider theme={appTheme} nonce="dAnIsRazNonCe"> |
There was a problem hiding this comment.
Isn't the nonce supposed to be randomly generated on every request?
There was a problem hiding this comment.
It should be, I'll look into this. This was actually worked on by another developer at the start of this project. Even if we remove this, we will be good. I'll give that a test and let you know.
| } | ||
| timeout = setTimeout(() => { | ||
| refreshCredentials(); | ||
| }, differenceInMilliseconds(new Date(credentials.expiration || 0), new Date()) - 300); |
There was a problem hiding this comment.
The previous logic didn't have the "- 300", why is that needed now?
There was a problem hiding this comment.
Credentials are refreshed 5 mins before expiration. I see that the 300 is incorrect, I'll update this ASAP.
Update branch with main
|
@mbalfour-amzn raising another PR, since the PR I raised from forked repo shows conflicts |
|
@mbalfour-amzn this PR has been marked as stale and moved in draft. You can find the updated PR here that resolves the comments in this PR. This PR can be closed and branch deleted. |
mbalfour-amzn
deleted the
enhancement_ALS-1792_update-creds-and-websocket-implementation
branch
This PR has the following changes;
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.