Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan pod if unknown owner #16

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

Bourne-ID-Work
Copy link
Contributor

@Bourne-ID-Work Bourne-ID-Work commented Jun 12, 2023

Relates to #13

Previous output:

❯ kubectl dds -n gha-rbourne
could not find resource manager for type Runner for pod gha-rbourne-12345-67890
NAMESPACE	TYPE	NAME	STATUS
❯

New Output:

could not find resource manager for type Runner for pod gha-rbourne-12345-67890
NAMESPACE                       TYPE    NAME                                            STATUS  
gha-rbourne-hackathon-2023      pod     gha-rbourne-12345-67890     mounted 

At this time I believe it is more worthwhile outputting low level pods when the owner is unknown understanding this can be verbose for clusters with large numbers of pods with docker host mounts, however the existing error does not make it clear the pod in question was not scanned.

@Bourne-ID-Work Bourne-ID-Work marked this pull request as ready for review June 12, 2023 02:37
@rothgar
Copy link
Contributor

rothgar commented Jun 12, 2023

I agree we should probably output something even if the type isn't known. Can you also add output if the user passes --verbose to always show the output (even if unmounted)?

@Bourne-ID-Work
Copy link
Contributor Author

Sure, will make the edits later today.

@sidewinder12s
Copy link

Also stumbled onto this, we missed a bunch of docker.sock mounts because I dismissed the could not find error without investigating.

@rothgar rothgar merged commit 1f3ca2b into aws-containers:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants