FIX: failed to ap-northeast-1 using Mac #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayoshi644
changed the title
|
@adamjkeller @InbarRose @thelateperseus |
|
@paprika-mah I'm not a maintainer of this repository so I can't merge this PR. But I can confirm that your updated script still works for me on Windows using cygwin. |
|
@thelateperseus @toricls |
|
hey @paprika-mah! Thanks for the PR, I am going to check out why the build is failing and will get this merged very soon. Apologies for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed this bug report! ( #53 ) Here bug is from this #48, so I modified the codes so that It doesn't use sed.
Please review it.