Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-storage): use aws-amplify's internals APIs #5903

Open
wants to merge 9 commits into
base: feat-storage-browser/main
Choose a base branch
from

Conversation

Samaritan1011001
Copy link
Member

@Samaritan1011001 Samaritan1011001 commented Oct 14, 2024

Description of changes

  • Updates the aws-amplify version to storage-browser-integrity
  • Updates all the imports to use /internals
  • Update test files to import and mock /internals APIs

Issue #, if available

Description of how you validated changes

  • yarn test
  • Manual test on the next app.

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: e966120

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Samaritan1011001 Samaritan1011001 changed the title feat(Storage): integrity changes to storage browser including internals API usage feat(Storage): use aws-amplify's internals APIs Oct 15, 2024
@Samaritan1011001 Samaritan1011001 changed the title feat(Storage): use aws-amplify's internals APIs feat(storage): use aws-amplify's internals APIs Oct 15, 2024
@Samaritan1011001 Samaritan1011001 changed the title feat(storage): use aws-amplify's internals APIs feat(react-storage): use aws-amplify's internals APIs Oct 15, 2024
@Samaritan1011001 Samaritan1011001 marked this pull request as ready for review October 15, 2024 23:54
@Samaritan1011001 Samaritan1011001 requested a review from a team as a code owner October 15, 2024 23:54
AllanZhengYP
AllanZhengYP previously approved these changes Oct 15, 2024
Comment on lines -41 to -42
// @ts-expect-error `list` returns a union type of `ListPaginateOutput` | `ListAllOutput`
// causing the spy to yell due to the lack of `nextToken` on `ListAllOutput`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants