fix: removed unused import, type-checked before .replace

aws-amplify · Jul 11, 2024 · 14e72ac · 14e72ac
1 parent f3701a8
commit 14e72ac
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/packages/react/src/primitives/Tabs/TabsContainer.tsx b/packages/react/src/primitives/Tabs/TabsContainer.tsx
@@ -8,7 +8,6 @@ import { BaseTabsProps, TabsProps } from './types';
 import { View } from '../View';
 import { TabsContext } from './TabsContext';
 import { useStableId } from '../utils/useStableId';
-import { WHITESPACE_VALUE } from './constants';
 
 const TabsContainerPrimitive: Primitive<TabsProps, 'div'> = (
  {

diff --git a/packages/react/src/primitives/Tabs/TabsItem.tsx b/packages/react/src/primitives/Tabs/TabsItem.tsx
@@ -19,7 +19,10 @@ const TabsItemPrimitive: Primitive<TabsItemProps, 'button'> = (
  ref
 ) => {
  const { activeTab, setActiveTab, groupId } = React.useContext(TabsContext);
- const idValue = value.replace(' ', WHITESPACE_VALUE);
+ let idValue = value;
+ if (typeof idValue === 'string') {
+ idValue = idValue.replace(' ', WHITESPACE_VALUE);
+ }
  const isActive = activeTab === value;
  const handleOnClick = (e: React.MouseEvent<HTMLButtonElement>) => {
  if (isTypedFunction(onClick)) {

diff --git a/packages/react/src/primitives/Tabs/TabsPanel.tsx b/packages/react/src/primitives/Tabs/TabsPanel.tsx
@@ -18,7 +18,10 @@ const TabPanelPrimitive: Primitive<TabsPanelProps, 'div'> = (
 
  if (isLazy && activeTab !== value) return null;
 
- const idValue = value.replace(' ', WHITESPACE_VALUE);
+ let idValue = value;
+ if (typeof idValue === 'string') {
+ idValue = idValue.replace(' ', WHITESPACE_VALUE);
+ }
 
  return (
  <View