-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): adding support for email mfa #3862
Open
harsh62
wants to merge
11
commits into
main
Choose a base branch
from
feat/email-mfa-support-public
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
reviewed
Sep 13, 2024
AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Support/Helpers/UserPoolSignInHelper.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3862 +/- ##
==========================================
+ Coverage 68.14% 68.18% +0.04%
==========================================
Files 1085 1085
Lines 37992 38062 +70
==========================================
+ Hits 25889 25952 +63
- Misses 12103 12110 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruisebas
previously approved these changes
Sep 20, 2024
harsh62
had a problem deploying
to
IntegrationTest
September 27, 2024 14:59
— with
GitHub Actions
Failure
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 14:59
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 14:59
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 14:59
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
September 27, 2024 15:23
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:00
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:00
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:00
— with
GitHub Actions
Inactive
harsh62
had a problem deploying
to
IntegrationTest
October 3, 2024 01:00
— with
GitHub Actions
Failure
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 01:49
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 14:42
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 14:42
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 14:42
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 3, 2024 14:42
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 15, 2024 17:25
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 15, 2024 17:25
— with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
October 15, 2024 17:25
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR aims to add support for Email MFA that has been released by Cognito.
https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pool-settings-advanced-security-email-mfa.html
Depends upon the Swift SDK being upgraded to the latest version with Email MFA models:
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.