Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Auth): Adding credentialsProvider to Cognito clients #3745

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jun 10, 2024

Issue #

#3743

Description

When initializing the Cognito client, there was no credentialsProvider initialized. This change introduce the initialization of the credentialsProvider from the AuthService.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 marked this pull request as ready for review June 10, 2024 21:09
@harsh62 harsh62 requested a review from a team as a code owner June 10, 2024 21:09
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.44%. Comparing base (53d0fff) to head (86b68b7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3745   +/-   ##
=======================================
  Coverage   68.43%   68.44%           
=======================================
  Files        1079     1079           
  Lines       37569    37573    +4     
=======================================
+ Hits        25711    25715    +4     
  Misses      11858    11858           
Flag Coverage Δ
API_plugin_unit_test 68.83% <ø> (-0.04%) ⬇️
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.65% <ø> (+0.06%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.44% <100.00%> (+0.01%) ⬆️
DataStore_plugin_unit_test 81.17% <ø> (-0.06%) ⬇️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.32% <ø> (ø)
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.75% <ø> (ø)
unit_tests 68.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harsh62 harsh62 merged commit c719161 into main Jun 11, 2024
79 checks passed
@harsh62 harsh62 deleted the fix/3743 branch June 11, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants