-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): use custom HTTPClient for HTTP Requests #3582
Conversation
Integration tests: https://github.com/aws-amplify/amplify-swift/actions/runs/8396784921 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 68.42% 68.20% -0.23%
==========================================
Files 1077 1087 +10
Lines 36294 37043 +749
==========================================
+ Hits 24835 25264 +429
- Misses 11459 11779 +320
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue #
In #3519, we upgraded
aws-sdk-swift
dependency to0.36.1
and removed our custom http client engine to useaws-sdk-swift
HTTP Client for making HTTP requests. This is causing latency increase in release/production builds for customers when making Auth category API calls(fetchAuthSession()/signIn()). This was released in 2.27.0.Description
This PR reverts the change to use our custom HTTP Client which was used in 2.26.3 where the customer has confirmed that they are not experiencing the issue.
General Checklist
Given When Then
inline code documentation and are named accordinglytestThing_condition_expectation()
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.