feat(datastore): support of custom primary key #1641
Conversation
HuiSF
force-pushed
the
feat/custom-primary-key
branch
from
ee39794
to
9c16236
Compare
HuiSF
force-pushed
the
feat/custom-primary-key
branch
from
9c16236
to
5a97c8a
Compare
HuiSF
force-pushed
the
feat/custom-primary-key
branch
from
5a97c8a
to
d208a7b
Compare
packages/amplify_datastore/ios/Classes/utils/modelHelpers.swift
Outdated
Show resolved
Hide resolved
| @@ -30,7 +30,6 @@ class FlutterSubscriptionDataProcessedEvent( | |||
| "modelName" to model.modelName, | |||
| "element" to mapOf( | |||
| "syncMetadata" to mapOf( | |||
| "id" to syncMetadata.id, | |||
There was a problem hiding this comment.
Isn't this important to include?
There was a problem hiding this comment.
With custom primary key, id is no longer a mandatory field.
Model identifier (either transition single id field, or a composite key formed by multiple model fields) can always be determined by schema + model fields values. In addition, this field has not been used any where. So this field can be safely removed.
| fun toValueMap(): Map<String, Any?> { | ||
| return mapOf( | ||
| "id" to this.metadata.model.id, |
There was a problem hiding this comment.
Same question -
Isn't this important to include?
| .modelSchema(schema) | ||
| .serializedData(serializedModelData) |
There was a problem hiding this comment.
I'm guessing the order here matters which is why you've made the change throughout? If that's the case, can we possibly create a wrapper class/method that abstracts away the need to remember this? It seems like an easy thing to miss.
There was a problem hiding this comment.
It's due to builder step interface change in amplify-android.
We don't need to remember the order, compiler will let us know if the order is wrong. So we don't need a wrapper either.
HuiSF
force-pushed
the
feat/custom-primary-key
branch
2 times, most recently
from
cc9babb
to
1a50262
Compare
- CRLF to LF - Source code reformatting and fixing linter issues
HuiSF
force-pushed
the
feat/custom-primary-key
branch
3 times, most recently
from
b9afc16
to
90f1a44
Compare
- Add ModelIndex ModelIdentifier interface - Make Model non-abstract class to prevent unnecessary breaking changes - Add indexes to model schema - Add query by model identifier interface
HuiSF
force-pushed
the
feat/custom-primary-key
branch
from
90f1a44
to
6470937
Compare
HuiSF
force-pushed
the
feat/custom-primary-key
branch
from
6470937
to
3f81e0b
Compare
!!Do not merge until required versions of amplify-ios and amplify-android are released.
Recommend to review by commit.
PR checks will fail as required amplify-ios and amplify-android interface changes do not exist yet.
Issue #, if available:
#1426
Description of changes:
Pending Changes
[ ] GraphQL API model helper user case(out of scope)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.