feat(datastore): implement custom primary key functionality #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
feat/custom-pk-model-index
branch
from
fde239a
to
b968355
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/custom-pk #1517 +/- ##
==================================================
- Coverage 46.32% 36.34% -9.99%
==================================================
Files 263 244 -19
Lines 10229 8191 -2038
==================================================
- Hits 4739 2977 -1762
+ Misses 5490 5214 -276
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dnys1
approved these changes
Apr 19, 2022
| @@ -19,661 +19,664 @@ import com.amplifyframework.core.model.* | |||
| import com.amplifyframework.core.model.temporal.Temporal | |||
|
|
|||
| val postSchema = ModelSchema.builder() | |||
There was a problem hiding this comment.
Do any of these need to be updated with indexes? Or should we add one with indexes?
There was a problem hiding this comment.
The test model Post has a SDI defined, the index info has been added to this testing model and its schema, see line 24 - 26. And it's asserted by unit tests. iOS impl. has similar changes too.
…ards compatibility
- FlutterModelPrimaryKey implementation - Query by identifier (ModelPrimaryKey) using new amplify-android API - Required code changes to fit the newly updated interface in amplify-android - Fixing exiting unit tests
HuiSF
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1426
Description of changes:
Create native objects presenting model indexes and let native storage engine create data tables with expected indexes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.