Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(liveness): Liveness web socket expiration retry #2615

Merged
merged 20 commits into from
Nov 9, 2023

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Oct 23, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
If device time is out of sync with true server time, skew the time sent to the Liveness websocket by that offset (calculated via server response vs. device time) and retry.

How did you test these changes?
tested on gamma where liveness team has implemented the header.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #2615 (a2add16) into main (cdc905b) will increase coverage by 0.04%.
The diff coverage is 54.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
+ Coverage   41.72%   41.77%   +0.04%     
==========================================
  Files         900      901       +1     
  Lines       28870    28965      +95     
  Branches     4105     4102       -3     
==========================================
+ Hits        12047    12100      +53     
- Misses      15494    15538      +44     
+ Partials     1329     1327       -2     

@tjleing tjleing marked this pull request as ready for review October 28, 2023 02:43
@tjleing tjleing requested a review from a team as a code owner October 28, 2023 02:43
Copy link
Contributor

@gpanshu gpanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added

Copy link
Member

@tylerjroach tylerjroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see Ankit's date parsing concern. Outside of this, I am ok with PR.

@gpanshu gpanshu enabled auto-merge (squash) November 9, 2023 15:25
@gpanshu gpanshu merged commit acdaa9e into main Nov 9, 2023
5 checks passed
@gpanshu gpanshu deleted the liveness-web-socket-expiration-retry branch November 9, 2023 15:26
gpanshu added a commit that referenced this pull request Nov 9, 2023
@tjleing tjleing restored the liveness-web-socket-expiration-retry branch November 10, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants