Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove test for unsupported api #2610

Merged
merged 7 commits into from
Oct 31, 2023
Merged

chore: Remove test for unsupported api #2610

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b2c723
Remove test for unsupported api
tylerjroach Oct 17, 2023
6860184
Merge branch 'main' into tjroach/remove-16-test
gpanshu Oct 17, 2023
8503400
lint
tylerjroach Oct 17, 2023
2f2b81f
Merge remote-tracking branch 'origin/tjroach/remove-16-test' into tjr…
tylerjroach Oct 17, 2023
fee19bf
Merge branch 'main' into tjroach/remove-16-test
tylerjroach Oct 20, 2023
4749b2e
Merge branch 'main' into tjroach/remove-16-test
gpanshu Oct 25, 2023
382431c
Merge branch 'main' into tjroach/remove-16-test
tylerjroach Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions aws-api/src/test/java/com/amplifyframework/api/aws/AWSApiPluginUserAgentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.json.JSONObject;
import org.junit.After;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
Expand Down Expand Up @@ -89,28 +88,6 @@ public void tearDown() throws IOException {
server.shutdown();
}

/**
* Make an API request to the mock server and check the user agent
* header format on the request. Verify that the Android version is
* accurately reflected on the user agent.
* @throws Exception if API call fails or thread is interrupted while
* waiting for request
*/
@Test
@Config(sdk = 16)
@Ignore("minSDKVersion changed to 24 in favor of AWS Kotlin SDK dependency")
public void testUserAgentWithApi16() throws Exception {
String userAgent = checkUserAgent();

// Assert the correct format and content
assertNotNull(userAgent);
Matcher regexMatcher = USER_AGENT_PATTERN.matcher(userAgent);
assertTrue(regexMatcher.matches());
assertEquals("amplify-android", regexMatcher.group("libraryName"));
assertEquals("Android", regexMatcher.group("systemName"));
assertEquals("4.1.2", regexMatcher.group("systemVersion"));
}

/**
* Make an API request to the mock server and check the user agent
* header format on the request. systemName and systemVersion not
Expand Down
Loading