Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for d-link e-520 and more from https://github.com/bb-qq/r8152 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikitosiusis
Copy link

Good day
I suggest using r8152 driver from synology, because it additionally supports more chips, like d-link e-520

@awesometic
Copy link
Owner

Hello,

Thanks for your contribution :)
It'd be nice if it supports more devices. But how can we test if it is working? Do you have Synology?
I mean, if it doesn't have any side effects and all the additional codes working fine, I will apply this patch after every update from Realtek.

@nikitosiusis
Copy link
Author

I don't have a synology, but I have a d-link e-520(it uses 2.5g rtl8156) .
Driver from your repo didn't support it out of the box
With driver from bb-rq it started to work.
I just replaced the driver in your repo with their driver, to get dkms support. Sadly I cannot test any other adapters :)

@awesometic
Copy link
Owner

Ah okay,

Then how about making a commit only for supporting the other devices?

Seems this change has other things like: bb-qq/r8152@1f24cbb

If you want, you can make a new patch by overwriting this commit using --amend.
Or, I can make a new one, and maybe you can help me for the test :)

@nikitosiusis
Copy link
Author

nikitosiusis commented Nov 8, 2022

Yes, I think we need to amend this commit, because it is not mine actually, but I have no idea how to do it properly:)
I just used your repo for dkms module for my d-link e-520 on my laptop. It didn't work, so I got a driver from another repo. Now it works.
As far as I understand, other commits to the driver in their repo only affect building on old platforms(kernels?), I believe old platforms don't use dkms :)
I can help you with testing, but the only adapter I have is that d-link e-520.
I also use your repo for r8125 and it works great.

@awesometic
Copy link
Owner

Thank you :) I am glad to hear that my r8125-dkms also works great for you.

Then, I will look into the changes to apply only supporting the additional devices.
Except supporting old devices.

And I hope you can test my new upcoming builds. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants