Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bluesky PDS #971

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

henningta
Copy link

Thanks for taking the time to suggest an addition to awesome-selfhosted!

To ensure your Pull Request is dealt with swiftly, please check the following (check the boxes [x]):

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any software you are adding is not already listed at any of awesome-sysadmin, staticgen.com, staticsitegenerators.net, dbdb.io.
  • The file you are adding is formatted as described in addition.md.
  • Demo links should only be used for interactive demos, i.e. not video demonstrations.
  • Comments and unused optional fields have been removed.
  • The file you are adding uses kebab-case file naming, for example my-awesome-software.yml.
  • Values for platform are the main server-side requirements for the software. Don't include frameworks or specific dialects.
  • Any software project you are adding to the list is actively maintained.
  • Any software project you are adding was first released more than 4 months ago.
  • Any software project you are adding has working installation instructions.
  • You understand that your Pull Request will be merged ~1 week after approval, to allow for further comments if needed.

@Rabenherz112 Rabenherz112 added addition Adding new software to the list reviewers wanted Awaiting reviews labels Nov 22, 2024
software/bluesky-pds.yml Outdated Show resolved Hide resolved
Remove Nodejs as listed dependency

Co-authored-by: kokomo123 <[email protected]>
Copy link
Collaborator

@kokomo123 kokomo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending other thoughts from collaborators. Thank you for your contribution!

nodiscc
nodiscc previously requested changes Dec 8, 2024
software/bluesky-pds.yml Show resolved Hide resolved
@kokomo123
Copy link
Collaborator

kokomo123 commented Jan 3, 2025

pinging @henningta for above change requested ^

@Ki-er
Copy link
Collaborator

Ki-er commented Jan 19, 2025

More than a month without response, I think we can close this and reopen if needed.

@Ki-er Ki-er closed this Jan 19, 2025
@henningta
Copy link
Author

Ah, my apologies! I was gone on an extended leave, and I only recently got back. Missed these change requests.

I did have one concern about the recent request to remove shell. I am using docker on my personal setup to host this, but it looks like they do provide an option to run it on bare metal, So I figured listing docker/shell both as options would cover each of those scenarios.

I assume docker is the way most people will run it, but it does seem like both options are viable. In any case, sorry again, if you open it back up, we can get it knocked out soon.

@kokomo123
Copy link
Collaborator

I shall reopen it now! I agree with your comments regarding docker/shell, and we should keep it that way.

@kokomo123 kokomo123 reopened this Jan 19, 2025
@nodiscc nodiscc dismissed their stale review January 19, 2025 19:33

old review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding new software to the list reviewers wanted Awaiting reviews
Development

Successfully merging this pull request may close these issues.

5 participants