Improve handling of "Date" header field #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under normal circumstances the "Date" header is added by mailmerge - just as it always has been. If "Date" header is already present (from the template) - a new "Date" header is not added. If "Date" header is already present but empty - then delete it Summary: If the "Date" is to be left out - then just add an empty "Date" header into the template This presents a (backwards compatible) way to let the mail-system add its own "Date" upon queuing into mail-queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of "Date" header field
Under normal circumstances the "Date" header is added by mailmerge - just as it always has been.
If "Date" header is already present (from the template) - a new "Date" header is not added.
If "Date" header is already present but empty - then delete it
Tests for new functionality included.
Summary:
If the "Date" is to be left out - then just add an empty "Date" header into the template
This presents a (backwards compatible) way to let the mail-system add its own "Date" upon queuing into mail-queue.
This PR is related to issue #162