Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint error #161

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Fix pylint error #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
663c69b
Fix pylint error
awdeorio Nov 1, 2024
e6237c7
bump GH Action CodeCov version
awdeorio Nov 4, 2024
35cfea9
Merge remote-tracking branch 'origin/develop' into lint-fix
awdeorio Nov 4, 2024
4a6af96
Configure CodeCov token from GH Secrets
awdeorio Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ jobs:
# Upload coverage report
# https://github.com/codecov/codecov-action
- name: Upload coverage report
uses: codecov/codecov-action@v2
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
slug: awdeorio/mailmerge
fail_ci_if_error: true
7 changes: 2 additions & 5 deletions mailmerge/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
type=click.Choice(["colorized", "text", "raw"]),
help="Output format (colorized).",
)
def main(sample, dry_run, limit, no_limit, resume,
def main(*, sample, dry_run, limit, no_limit, resume,
template_path, database_path, config_path,
output_format):
"""
Expand All @@ -74,7 +74,6 @@
# We need an argument for each command line option. That also means a lot
# of local variables.
# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
# pylint: disable=too-many-locals

# Convert paths from string to Path objects
Expand Down Expand Up @@ -143,9 +142,7 @@


if __name__ == "__main__":
# No value for parameter, that's how click works
# pylint: disable=no-value-for-parameter
main()
main() # pylint: disable=missing-kwoa

Check warning on line 145 in mailmerge/__main__.py

View check run for this annotation

Codecov / codecov/patch

mailmerge/__main__.py#L145 

Added line #L145 was not covered by tests


def check_input_files(template_path, database_path, config_path, sample):
Expand Down
Loading