Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for NTLM authentication #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodingMarco
Copy link

This PR adds support for NTLM (Windows/AD) authentication.
The --openssl-legacy-provider is not strictly required for node 16 which is currently used by the Dockerfile but it will be required when the Dockerfile is updated to node >= 17 according to the Tedious documentation. So I included the flag for forward-compatibility.

@CodingMarco CodingMarco changed the title Add support for NTLM authentication WIP: Add support for NTLM authentication Apr 18, 2023
@CodingMarco
Copy link
Author

I see that the --openssl-legacy-provider doesn't work for node 16. @awaragi would it be an option to update the node version used by the docker container to 17 or should I remove the flag to be compatible with node 16? I think most people will have a recent node version on their machines, so I would suggest updating the version used in the Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant