Use Parallel.ForEachAsync() in the inverter loop

awaescher · Jun 12, 2024 · 060af42 · 060af42
1 parent 13142e4
commit 060af42
Showing 1 changed file with 63 additions and 46 deletions.
diff --git a/MaxPower/HostedServices/ExporterService.cs b/MaxPower/HostedServices/ExporterService.cs
@@ -5,50 +5,67 @@ namespace MaxPower.HostedServices;
 
 public class ExporterService(MaxSettings maxSettings, IEnumerable<InverterConfiguration> inverters, IMaxTalkClient maxTalkClient, ILogger<ExporterService> logger) : BackgroundService
 {
-	private Gauge _energyDay = Metrics.CreateGauge("maxpower_energy_day_kwh", "The amount of energy created today in kWh", ["ip", "id"]);
-	private Gauge _energyMonth = Metrics.CreateGauge("maxpower_energy_month_kwh", "The amount of energy created this month in kWh", ["ip", "id"]);
-	private Gauge _energyYear = Metrics.CreateGauge("maxpower_energy_year_kwh", "The amount of energy created this year in kWh", ["ip", "id"]);
-	private Gauge _energyTotal = Metrics.CreateGauge("maxpower_energy_total_kwh", "The amount of energy created in total in kWh", ["ip", "id"]);
-
-	public MaxSettings MaxSettings { get; } = maxSettings ?? throw new ArgumentNullException(nameof(maxSettings));
-	public IEnumerable<InverterConfiguration> Inverters { get; } = inverters ?? throw new ArgumentNullException(nameof(inverters));
-	public IMaxTalkClient MaxTalkClient { get; } = maxTalkClient ?? throw new ArgumentNullException(nameof(maxTalkClient));
-	public ILogger Logger { get; } = logger ?? throw new ArgumentNullException(nameof(logger));
-
-	protected override async Task ExecuteAsync(CancellationToken cancellationToken)
-	{
-		while (!cancellationToken.IsCancellationRequested)
-		{
-			foreach (var inverter in Inverters)
-			{
-				if (cancellationToken.IsCancellationRequested)
-					return;
-
-				Logger.LogInformation("Reading data from inverter {inverterId} at {inverterIp}:{inverterPort} ...", inverter.Id, inverter.Ip, inverter.Port);
-
-				string[] labels = [inverter.Ip, inverter.Id.ToString()];
-
-				MaxValues? data = null;
-
-				try
-				{
-					data = await MaxTalkClient.RequestAsync(inverter.Ip, inverter.Id, inverter.Port, timeout: 8000, cancellationToken);
-					Logger.LogInformation("Inverter {inverterId} made {energyDay} kWh today.", inverter.Id, data.EnergyDay);
-				}
-				catch (Exception ex)
-				{
-					var message = "An error occured while executing inverter {inverterId} at {inverterIp}:{inverterPort}.\r\nMessage: {message}";
-					Logger.LogError(ex, message, inverter.Id, inverter.Ip, inverter.Port, ex.Message + Environment.NewLine + ex.InnerException?.Message ?? "");
-				}
-
-				_energyDay.WithLabels(labels).Set(data?.EnergyDay ?? 0);
-				_energyMonth.WithLabels(labels).Set(data?.EnergyMonth ?? 0);
-				_energyYear.WithLabels(labels).Set(data?.EnergyYear ?? 0);
-				_energyTotal.WithLabels(labels).Set(data?.EnergyTotal ?? 0);
-			}
-
-			Logger.LogInformation($"Entering sleep state for {MaxSettings.PollIntervalSeconds} seconds.");
-			await Task.Delay(TimeSpan.FromSeconds(MaxSettings.PollIntervalSeconds), cancellationToken);
-		}
-	}
+    private Gauge _energyDay = Metrics.CreateGauge("maxpower_energy_day_kwh", "The amount of energy created today in kWh", ["ip", "id"]);
+    private Gauge _energyMonth = Metrics.CreateGauge("maxpower_energy_month_kwh", "The amount of energy created this month in kWh", ["ip", "id"]);
+    private Gauge _energyYear = Metrics.CreateGauge("maxpower_energy_year_kwh", "The amount of energy created this year in kWh", ["ip", "id"]);
+    private Gauge _energyTotal = Metrics.CreateGauge("maxpower_energy_total_kwh", "The amount of energy created in total in kWh", ["ip", "id"]);
+
+    public MaxSettings MaxSettings { get; } = maxSettings ?? throw new ArgumentNullException(nameof(maxSettings));
+    public IEnumerable<InverterConfiguration> Inverters { get; } = inverters ?? throw new ArgumentNullException(nameof(inverters));
+    public IMaxTalkClient MaxTalkClient { get; } = maxTalkClient ?? throw new ArgumentNullException(nameof(maxTalkClient));
+    public ILogger Logger { get; } = logger ?? throw new ArgumentNullException(nameof(logger));
+
+    protected override async Task ExecuteAsync(CancellationToken cancellationToken)
+    {
+        while (!cancellationToken.IsCancellationRequested)
+        {
+            await Parallel.ForEachAsync(Inverters, cancellationToken, async (inverter, cancellationToken) => await ProcessInverter(inverter, cancellationToken));
+
+            Logger.LogInformation("Entering sleep state for {pollinterval} seconds.", MaxSettings.PollIntervalSeconds);
+            await Task.Delay(TimeSpan.FromSeconds(MaxSettings.PollIntervalSeconds), cancellationToken);
+        }
+    }
+
+    private async Task ProcessInverter(InverterConfiguration inverter, CancellationToken cancellationToken)
+    {
+        if (cancellationToken.IsCancellationRequested)
+            return;
+
+        // add an additional (generous) timeout to prevent the system from hanging if the socket conection hangs.
+        // seems to happen sometimes after some hours of working perfectly ...
+        var cancellationTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
+        cancellationTokenSource.CancelAfter(TimeSpan.FromMinutes(10));
+
+        var scopeValues = new Dictionary<string, object>
+        {
+            ["inverterId"] = inverter.Id,
+            ["inverterIp"] = inverter.Ip,
+            ["inverterPort"] = inverter.Port
+        };
+
+        using (Logger.BeginScope(scopeValues))
+        {
+            Logger.LogInformation("Reading data from inverter {inverterId} at {inverterIp}:{inverterPort}) ...", inverter.Id, inverter.Ip, inverter.Port);
+
+            string[] labels = [inverter.Ip, inverter.Id.ToString()];
+
+            MaxValues? data = null;
+
+            try
+            {
+                data = await MaxTalkClient.RequestAsync(inverter.Ip, inverter.Id, inverter.Port, timeout: 8000, cancellationTokenSource.Token);
+                Logger.LogInformation("Inverter {inverterId} made {energyDay:n1} kWh today.", inverter.Id, data.EnergyDay);
+            }
+            catch (Exception ex)
+            {
+                var message = "An error occured while executing inverter {inverterId} at {inverterIp}:{inverterPort}.\r\nMessage: {message}";
+                Logger.LogError(ex, message, inverter.Id, inverter.Ip, inverter.Port, ex.Message + Environment.NewLine + ex.InnerException?.Message ?? "");
+            }
+
+            _energyDay.WithLabels(labels).Set(data?.EnergyDay ?? 0);
+            _energyMonth.WithLabels(labels).Set(data?.EnergyMonth ?? 0);
+            _energyYear.WithLabels(labels).Set(data?.EnergyYear ?? 0);
+            _energyTotal.WithLabels(labels).Set(data?.EnergyTotal ?? 0);
+        }
+    }
 }