Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNU readline to mingw github action #1576

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Nov 20, 2023

This is an improved version of PR#1513 which fixes the issue of bringing in undesired dependency libwinpthread-1.dll.

Reference:

This will prevent the dependency to libwinpthread-1.dll.
@mcuee mcuee added the enhancement New feature or request label Nov 20, 2023
@mcuee
Copy link
Collaborator Author

mcuee commented Nov 20, 2023

If we can fix #1271 then it is better not to use GNU Readline with MinGW. Unfortunately PR #1553 does not work. So this is a compromised solution.

@mcuee
Copy link
Collaborator Author

mcuee commented Nov 20, 2023

Testing the mingw64 binary generated by github action:
https://github.com/avrdudes/avrdude/actions/runs/6926969540

 MINGW64 /c/work/avr/avrdude_test/avrdude_bin/github/pr1576
$ ldd ./avrdude.exe
        ntdll.dll => /c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffc2f650000)
        KERNEL32.DLL => /c/WINDOWS/System32/KERNEL32.DLL (0x7ffc2ea80000)
        KERNELBASE.dll => /c/WINDOWS/System32/KERNELBASE.dll (0x7ffc2cd30000)
        ADVAPI32.dll => /c/WINDOWS/System32/ADVAPI32.dll (0x7ffc2f180000)
        msvcrt.dll => /c/WINDOWS/System32/msvcrt.dll (0x7ffc2eb60000)
        sechost.dll => /c/WINDOWS/System32/sechost.dll (0x7ffc2e500000)
        RPCRT4.dll => /c/WINDOWS/System32/RPCRT4.dll (0x7ffc2f290000)
        SETUPAPI.dll => /c/WINDOWS/System32/SETUPAPI.dll (0x7ffc2e610000)
        HID.DLL => /c/WINDOWS/SYSTEM32/HID.DLL (0x7ffc28080000)
        cfgmgr32.dll => /c/WINDOWS/System32/cfgmgr32.dll (0x7ffc2d0d0000)
        ucrtbase.dll => /c/WINDOWS/System32/ucrtbase.dll (0x7ffc2d5b0000)
        bcrypt.dll => /c/WINDOWS/System32/bcrypt.dll (0x7ffc2d580000)
        USER32.dll => /c/WINDOWS/System32/USER32.dll (0x7ffc2ec00000)
        win32u.dll => /c/WINDOWS/System32/win32u.dll (0x7ffc2d030000)
        GDI32.dll => /c/WINDOWS/System32/GDI32.dll (0x7ffc2f080000)
        gdi32full.dll => /c/WINDOWS/System32/gdi32full.dll (0x7ffc2d330000)
        msvcp_win.dll => /c/WINDOWS/System32/msvcp_win.dll (0x7ffc2d4e0000)
        WS2_32.dll => /c/WINDOWS/System32/WS2_32.dll (0x7ffc2f0b0000)

@stefanrueger stefanrueger merged commit bf1aa2b into avrdudes:main Nov 22, 2023
10 checks passed
@mcuee mcuee deleted the mingw_readline_test branch January 6, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants