-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change execution position of "silicon revision" check of "serialupdi.c" #1543
Merged
stefanrueger
merged 3 commits into
avrdudes:main
from
askn37:issue_serialupdi_REVID_check
Nov 3, 2023
Merged
Change execution position of "silicon revision" check of "serialupdi.c" #1543
stefanrueger
merged 3 commits into
avrdudes:main
from
askn37:issue_serialupdi_REVID_check
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please review as well to see if you have any concerns. Thanks. |
Test result is positive under Windows. I use MSYS2 clang64 compiler to avoid the issue of MSYS2 mingw64 compiler issue mentioned in #1529.
|
dbuchwald
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Looks good to me as well! |
Great. This PR should be good to go now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to change the execution position of the "silicon revision" reading code in "serialupdi.c" described in #1529 (comment).
effect:
This fixes an issue where it would run before entering "progmode" and could not run depending on the state of the target CPU.
Impact of the fix:
If the device is locked, do nothing. Just as you can't read the signature at this point, you can't read the silicon revision either.
Uncensored:
In the official data sheet, silicon revisions are written as "A1", "A2", "B3", etc., but the display codes here are reported to be "1.1", "1.2", "2.3", etc. If you are concerned, another discussion and agreement is required.
Ignore the "Programmer not responding" report in the log below as it is a side effect of the target not fully coming back from its hard reset state.
Build test environment
Test results when unlocking the device
Test results when device is locked