Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix svg caching #3471

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: fix svg caching #3471

merged 2 commits into from
Nov 28, 2024
+8 −6

Conversation

adrianthedev
Copy link
Collaborator

Description

Reverts #3470

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 28, 2024 •
edited
Loading

Code Climate has analyzed commit 1c1e3fd and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev changed the title refactor: remove bad caching fix: fix svg caching Nov 28, 2024
@adrianthedev adrianthedev added Fix and removed Refactor labels Nov 28, 2024
@adrianthedev adrianthedev merged commit 5a982a9 into main Nov 28, 2024
21 of 22 checks passed
@adrianthedev adrianthedev deleted the refactor/remove-inline-svg-bad-caching branch November 28, 2024 23:31
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@Paul-Bob Paul-Bob mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrianthedev