Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename Turbo Stream helpers to avoid clashes in user apps (#3462) #3467

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

dark-panda
Copy link
Contributor

@dark-panda dark-panda commented Nov 27, 2024

Description

Fixes #3462

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas - simple renaming, shouldn't require new comments
  • I have made corresponding changes to the documentation - doesn't seem to be any documentation referencing these methods
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Nov 27, 2024

Code Climate has analyzed commit 96e5ce1 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

This needs coordination from us to make sure that the private repositories also comply to the new API.
I'll leave @Paul-Bob to take it over.

@Paul-Bob Paul-Bob added the Fix label Dec 2, 2024
@Paul-Bob Paul-Bob merged commit 75b7cd2 into avo-hq:main Dec 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential name clashes with Avo::TurboStreamActionsHelper
3 participants