refactor: floating resource controls in table rows #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 19ddf6d and detected 0 issues on this pull request. View more on Code Climate. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -2,6 +2,8 @@ module Avo | |||
| class Configuration | |||
| include ResourceConfiguration | |||
|
|
|||
| #TODO: add a configuration switch that adds the necesarry classes | |||
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Corrected] Layout/LeadingCommentSpace: Missing space after #.
|
This PR has been marked as stale because there was no activity for the past 15 days. |
|
Random thought: What if the floating resource controls only appear on hover, similar to how they work in Gmail? |
|
Yup. Great idea. This PR would enable that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needs finishing up
Checklist:
Screenshots & recording