Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual image when thumbnail is not present #174

Closed
Tracked by #1598
petmongrels opened this issue May 9, 2024 · 5 comments
Closed
Tracked by #1598

Use actual image when thumbnail is not present #174

petmongrels opened this issue May 9, 2024 · 5 comments
Assignees

Comments

@petmongrels
Copy link
Contributor

petmongrels commented May 9, 2024

Tasks done

  • Use actual image when thumbnail is not present
  • Show full image in the carousel
  • Ability to download a file and open a file both (including for files with thumbnails missing)
@petmongrels petmongrels self-assigned this May 9, 2024
petmongrels added a commit to avniproject/avni-etl that referenced this issue May 10, 2024
petmongrels added a commit to avniproject/avni-server that referenced this issue May 10, 2024
petmongrels added a commit that referenced this issue May 10, 2024
…. removed duplicate code for media search into service. use middleware specific environment variables for middleware.js.
@petmongrels
Copy link
Contributor Author

changes in avni-server, avni-media, avni-etl

@AchalaBelokar
Copy link

  • not showing the analytic db value
  • [ ]

@AchalaBelokar
Copy link

AchalaBelokar commented May 14, 2024

tested with organisation joya@goonj

  • able to download the image through the the thumbnail
  • able to download the image through the carousel
  • try to download multiple images through download button it contains empty folder not contains any images
  • After clicking on image name full image is displaying on other tab
  • after clicking on image image tab is open we can click next an previous button

@himeshr
Copy link
Contributor

himeshr commented May 14, 2024

@petmongrels we have avni-media config in pre-release configured to work with S3 Urls for media content within the bucket "prerelease-user-media". Replacing them with Prod configurations will break convention we have followed across the system configuration and is not a good idea from long term maintenance perspective.

AVNI_MEDIA_S3_BUCKET_NAME: prerelease-user-media
AVNI_MEDIA_S3_ZIP_UPLOAD_BUCKET_NAME: prerelease-user-media

@himeshr
Copy link
Contributor

himeshr commented May 15, 2024

For the issue "try to download multiple images through download button it contains empty folder not contains any images"
We need to do away with usage of configured AVNI_MEDIA_S3_BUCKET_NAME info, and instead use Media URL specific AVNI_MEDIA_S3_BUCKET_NAME to get this working.

This would then start working, as we give all our AWS_ACCESS_KEYS privileges across all Buckets and their content objects and do not restrict them to a specific env (Prod, prerelease, staging, etc..) Buckets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants