Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter not applied at all address levels #1375

Closed
Tracked by #1575
vedfordev opened this issue Apr 12, 2024 · 7 comments
Closed
Tracked by #1575

Filter not applied at all address levels #1375

vedfordev opened this issue Apr 12, 2024 · 7 comments
Assignees

Comments

@vedfordev
Copy link
Contributor

vedfordev commented Apr 12, 2024

Describe the bug
When implementing a filter at the block level in Goonj, the dashboard card does not filter data that is at a higher level, such as District.

To Reproduce
Steps to reproduce the behaviour:

  1. Login with gvamp_uat user (maha@gvamp_uat)
  2. Apply filter like (Kerala -> Alappuzha -> Other)
  3. Check Demand to be dispatched (data is not filtered, as the Demand is registered at higher address level type => "District")

AC:

  • In the params pass all the selected locations as well(along with lower level locations implicitly selected) since subject might be registered at any address level
  • The standard report cards added to custom dashboard as well need to work inline with this (filter needs to be applied based on all locations(any level) selected and lower address levels implicitly)
  • Note the release number to make sure the commit is made in the needed branch

Analysis
Working in 7.1 but not in 7.2 which has fix for selection of lower address levels implicitly(#1283)

@mahalakshme
Copy link
Contributor

mahalakshme commented Apr 12, 2024

@vedfordev It doesn't work with 7.1.x - latest release as well?

@vedfordev
Copy link
Contributor Author

@mahalakshme not working

@mahalakshme
Copy link
Contributor

@vinayvenu are you aware of the priority for this?

@vinayvenu
Copy link
Member

Breaking an implementation

@mahalakshme mahalakshme moved this from New Issues to In Analysis in Avni Product Apr 15, 2024
@mahalakshme mahalakshme moved this from In Analysis to Requirements gathering in Avni Product Apr 15, 2024
@mahalakshme
Copy link
Contributor

@vinayvenu @vedfordev already working in 7.2 and 7.1 as well

WhatsApp.Video.2024-04-15.at.3.41.47.PM.mp4

Am I missing something?

@vinayvenu
Copy link
Member

We did a common debugging session. This is a product bug. Specifically, when choosing a lower level location, the higher locations do not show up in the address array of ruleInput. This is a problem when there are multiple cards, and some of them rely on subjects that are registered at a higher level.

@vinayvenu vinayvenu moved this from Requirements gathering to Ready in Avni Product Apr 15, 2024
@vinayvenu vinayvenu moved this from Ready to In Analysis in Avni Product Apr 15, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Apr 15, 2024
@mahalakshme mahalakshme changed the title Address Level Filter is Not Working Properly Filters at all address levels not applied Apr 15, 2024
@mahalakshme mahalakshme changed the title Filters at all address levels not applied Filters at all address levels applied Apr 16, 2024
@mahalakshme mahalakshme changed the title Filters at all address levels applied Filter at all address levels applied Apr 16, 2024
@mahalakshme mahalakshme changed the title Filter at all address levels applied Filter not applied at all address levels Apr 16, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Apr 17, 2024
@petmongrels petmongrels self-assigned this Apr 17, 2024
@petmongrels
Copy link
Contributor

@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Apr 18, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Apr 18, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Apr 18, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Apr 19, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Apr 22, 2024
@Dinesh2019 Dinesh2019 moved this from Done to QA Failed in Avni Product May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants