Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter frame not removed from Home page when removed from filter page #1391

Open
Dinesh2019 opened this issue May 3, 2024 · 4 comments
Open

Comments

@Dinesh2019
Copy link

Dinesh2019 commented May 3, 2024

Describe the bug

  1. If we remove the filter but still the filter applied shows as empty
My.Movie.mp4

2When applying a filter with "others" at a lower level, the location initially selected is displayed,it is not happening when selecting a different lower-level address

Reference video :

My.Movie.mp4
@mahalakshme
Copy link
Contributor

mahalakshme commented May 5, 2024

Scenario 3 : (need to understand)

 1.What occurs when we choose one address up to the village level and another address selected up to the district level? Will it display all the address details or only the details for the village?

Moved the Scenario 3 to comments so that scope of the bug is clear.

@Dinesh2019 kindly make sure the below when testing:

  • for scenario 3 -> it needs to behave in the same manner like it behaves in the search filters, all villages in the district and the particular village - would be the filter
  • can you also make sure this works as mentioned, in search filters as well?

The above 2 are not in the scope of this card.

@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product May 5, 2024
@mahalakshme mahalakshme removed the bug label May 5, 2024
@mahalakshme mahalakshme moved this from Ready to In Analysis in Avni Product May 5, 2024
@Dinesh2019
Copy link
Author

@mahalakshme Then scenario 3 is working fine

and for above 2 points do i need to create a separated card

@mahalakshme
Copy link
Contributor

@Dinesh2019 @vedfordev the first scenario seems to be a implementation issue because all the filters are getting passed to the card as shown below.
'addressFilter=====', [ { type: 'Address', taType: null, lterValue: { uuid: '924674dc-d32b-4276-b7b5-fb782f5511f2', name: 'Kerala', level: 4, type: 'State', parentUuid: null, isSelected: true }, { uuid: 'b340ca39-cbfa-471f-b554-bb70879e8140', name: 'Tamil Nadu', level: 4, type: 'State', parentUuid: null, isSelected: true }, { uuid: 'cfa69930-8f81-4dfc-b684-864f72dfbd01', name: 'Palakkad', level: 3, type: 'District', parentUuid: '924674dc-d32b-4276-b7b5-fb782f5511f2', typeUuid: '6b0db0bd-93ad-4f54-b09a-a8f935ba4d85', isSelected: true }, { uuid: '0b270379-1715-40c6-99a7-1e055969ff0a', name: 'Thiruvallur', level: 3, type: 'District', parentUuid: 'b340ca39-cbfa-471f-b554-bb70879e8140', typeUuid: '6b0db0bd-93ad-4f54-b09a-a8f935ba4d85', isSelected: true }, { uuid: '2e591eac-173b-463d-a2af-b806bc170f12', name: 'Other', level: 2, type: 'Block', parentUuid: 'cfa69930-8f81-4dfc-b684-864f72dfbd01', typeUuid: '3410e7a2-cefe-4fc7-94b4-6631656c548c', isSelected: true }, { uuid: '90ec12bb-4bf9-4beb-897b-8ff3f5b1ca8d', name: 'Other', level: 1, type: 'Village', parentUuid: '2e591eac-173b-463d-a2af-b806bc170f12' } ] } ]

@Dinesh2019 so I will remove the 1st scenario from this card and move it to comments for later reference:

When implementing a filter goonj filter is not updated as expected 

env : pre-release
org : goonj
user : beulah@gvamp_uat

Scenario 1 : 
1.If we apply the filter for each different location then it is working fine 
2.But the filter applied in multi location then the filter displayed is not as expected 


https://github.com/avniproject/avni-client/assets/127730126/61c9d62d-c8b1-4967-98d1-4431c5e21108

scenario 2 can be handled later - not urgent - since mostly users will remove it from the home page

@mahalakshme mahalakshme changed the title Filter not applied at all address levels Filter frame not removed from Home page when removed from filter page May 6, 2024
@mahalakshme
Copy link
Contributor

  • 1st case - edge case - will mostly click on cross button to remove all the filters
  • 2nd case - also an edge case - so not important to fix now since might not happen on the field
    - but when need to fix, we cant remove allowing the same location in multiple location hierarchies since this is just a filter problem, so for that in this case, we can show 2 Others and some tooltip that shows users the entire hierarchy, others solutions need to be brainstormed when fixing it.

@mahalakshme mahalakshme moved this from In Analysis to Triaged in Avni Product May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triaged
Development

No branches or pull requests

2 participants