Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoselect bottom locations in location filter #1283

Closed
Tracked by #1506
mahalakshme opened this issue Jan 25, 2024 · 10 comments
Closed
Tracked by #1506

Autoselect bottom locations in location filter #1283

mahalakshme opened this issue Jan 25, 2024 · 10 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jan 25, 2024

Need:

As shown in the video, as part of UX, the expectation would be that on selecting a location, say State, all districts below it will be selected. And on unselecting a state, all districts below it will get unselected. Unselection currently is working for one level, but not selection. This is an issue because of below 2 reasons:

  • In one of the org, a user is assigned a district. District contains many blocks and each block contains around 25 villages. When needed to filter at block level, making user to select all 25 villages will be time consuming.
  • UX reasons with respect to what user would probably expect.

Acceptance criteria:

-- 1. when a higher level location is selected say, a, automatically assume all the bottom locations(b,c,d,e,f,g) in the filter are selected though no need to show the selection in UI
-- 2. But when a particular location is selected(a and b) at a hierarchy level in the bottom, then only that location in that level is considered to be selected (a, b, d, e)
-- 3. Also when b is unselected, then all of b,c,d,e,f, and g needs to be considered selected.

  • Should work like above for filtering on standard report cards as well as custom report cards. For custom cards - pass all the locations considered to be selected as part of params.ruleInput. Apply this change for the org in focus for the custom report cards of Approval dashboard to verify the same.
  • Also should work as above when locations are selected via search.
Screenshot 2024-02-15 at 11 21 00 AM
  • Note the release no. Make the change in the needed branch accordingly.
  • Remove the message that says "Choose exact level at which subject is registered"
@mahalakshme mahalakshme converted this from a draft issue Jan 25, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Jan 25, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Hold in Avni Product Jan 30, 2024
@mahalakshme
Copy link
Contributor Author

mahalakshme commented Jan 30, 2024

will resume after getting feedback from client in focus to see if we can wait until UI/UX person joins.

@mahalakshme mahalakshme moved this from Hold to Ready in Avni Product Feb 15, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Feb 15, 2024
@petmongrels petmongrels self-assigned this Feb 15, 2024
@1t5j0y 1t5j0y assigned 1t5j0y and unassigned petmongrels Feb 15, 2024
1t5j0y added a commit that referenced this issue Feb 15, 2024
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Feb 15, 2024
@himeshr himeshr moved this from Code Review Ready to In Code Review in Avni Product Feb 16, 2024
@himeshr himeshr moved this from In Code Review to QA Ready in Avni Product Feb 16, 2024
@himeshr
Copy link
Contributor

himeshr commented Feb 16, 2024

@mahalakshme the message is changed as follows, will this do.?

    "addressFilterBehaviorHint": "(Choose exact level at which subject is registered)"
    "addressFilterBehaviorHint": "(Selection includes lower levels implicitly)"

@mahalakshme
Copy link
Contributor Author

@himeshr

  • A better one could be - '(Selection includes lower address levels implicitly)' - and it needs to be in both Search filters and custom dashboard filters.
  • The scope of the card was to fix for custom dashboard. Let me know if its handled for MyDashboard as well - so that I need not create card for it.

@himeshr
Copy link
Contributor

himeshr commented Feb 16, 2024

  • A better one could be - '(Selection includes lower address levels implicitly)' - and it needs to be in both Search filters and custom dashboard filters.
  1. The Helper text is only changed for Custom Dashboard filters, as understood from focus area in initial Acceptance criteria.
  2. This is not done for MyDashboard, would need a separate card for that.

@mahalakshme
Copy link
Contributor Author

@himeshr But my concern now is, it is inconsistent. The AC was to remove the message, since the working is same as in Search Filters and users are used to its working now. If we are adding message we need to add in both places.

@1t5j0y
Copy link
Contributor

1t5j0y commented Feb 16, 2024

@mahalakshme MyDashboard already behaves the expected way.

@mahalakshme
Copy link
Contributor Author

@1t5j0y can you please make the messaging consistent in both places - we can add the message in Search filters as well or remove it here.

@mahalakshme
Copy link
Contributor Author

@Dinesh2019 separated custom report cards testing to different story. You can pair with whoever tests it, to be able to test such cards in future.

1t5j0y added a commit that referenced this issue Feb 19, 2024
- Introduce new translation key so users on older versions don't see incorrect help text
@1t5j0y 1t5j0y moved this from In QA to Code Review Ready in Avni Product Feb 19, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Feb 19, 2024

Added message to search and older filters view.

@himeshr himeshr moved this from Code Review Ready to In Code Review in Avni Product Feb 19, 2024
@himeshr himeshr moved this from In Code Review to QA Ready in Avni Product Feb 19, 2024
@Dinesh2019
Copy link

@1t5j0y available for dev box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants