Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing datetime for time concept #1242

Closed
mahalakshme opened this issue Dec 21, 2023 · 6 comments
Closed

Storing datetime for time concept #1242

mahalakshme opened this issue Dec 21, 2023 · 6 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Dec 21, 2023

https://avni.freshdesk.com/a/tickets/3342 - Preliminary analysis in the ticket

Looks like when users use 4.0.3 version, time concepts are stored with datetime causing ETL to fail

select * from encounter where created_by_id in (7146, 5389, 6703);

In the above result, looked like when the above users used 4.0.3 lfe version the above issue has occurred and when used 4.0.5 version the issue has not occurred.

Confirm the same by checking in the app. If the above is not the case need to find root cause since recent encounters saved(for users using 4.0.3 version) also has this issue and reply accordingly in the ticket.

@mahalakshme mahalakshme converted this from a draft issue Dec 21, 2023
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Dec 21, 2023
@mahalakshme mahalakshme changed the title Storing datetime instead of just time Storing datetime for time concept Dec 21, 2023
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Dec 22, 2023
@petmongrels petmongrels self-assigned this Dec 22, 2023
@petmongrels petmongrels moved this from In Progress to Ready in Avni Product Dec 25, 2023
@petmongrels petmongrels removed their assignment Dec 25, 2023
@mahalakshme mahalakshme moved this from Ready to In Progress in Avni Product Dec 25, 2023
@mahalakshme mahalakshme moved this from In Progress to Ready in Avni Product Dec 25, 2023
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Dec 25, 2023
@petmongrels petmongrels self-assigned this Dec 25, 2023
@petmongrels
Copy link
Contributor

Cannot reproduce the issue on 4.0 branch

@mahalakshme
Copy link
Contributor Author

mahalakshme commented Dec 25, 2023

@petmongrels can you check with lfe 4.0.3 version specifically, bcoz found couple of entries created with lfe 4.0.5 version had time concept saved as time.

And our 4.0 branch I think might not indicate lfe 4.0 version. Need to check that.

@petmongrels
Copy link
Contributor

there is no tag for 4.0.3 and no apk to test with local

@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Dec 25, 2023
@mahalakshme
Copy link
Contributor Author

@petmongrels I am concerned that even if we run the data fix the issue will continue, since even 2 days back for encounter with id, 152375 this issue has occurred. Can you also please try to reproduce the issue with 4.0.3 prod apk and test with some UAT prod org? Let me know if you think otherwise.

@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 26, 2023
@1t5j0y 1t5j0y moved this from In Code Review to Code Review Ready in Avni Product Dec 26, 2023
@mahalakshme mahalakshme moved this from Code Review Ready to In Code Review in Avni Product Dec 26, 2023
@mahalakshme mahalakshme moved this from In Code Review to QA Ready in Avni Product Dec 26, 2023
@mahalakshme
Copy link
Contributor Author

@petmongrels we can run the datafix for this. The client has come back and asked for update. I think since its on prod better to pair with someone when running the fix. @sachsk already has context for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants