Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFE specific patch for not allowing date time values in time field #674

Closed
petmongrels opened this issue Dec 26, 2023 · 2 comments
Closed
Assignees

Comments

@petmongrels
Copy link
Contributor

petmongrels commented Dec 26, 2023

  • this patch is only to get to the root of the issue by blocking the users from syncing data and hence raising support request
  • need not be merged to 6.x, master
  • do only for encounter
  • throw error if string is not null or great than 5 chars
  • by failing the user, it allows ETL process to continue un-interrupted

after Deployment

  • at the time of deployment check if there any records with datetime in db then make them null using data fix sql done earlier
  • Move the flag "lfe_prod" to latest commit done as part of this card on 5.1.0 branch on avni-server
  • update this sheet
  • close the ticket
  • For the ticket and data fix details refer this card
@petmongrels petmongrels self-assigned this Dec 26, 2023
@petmongrels petmongrels converted this from a draft issue Dec 26, 2023
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Dec 26, 2023
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 26, 2023
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Dec 26, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Dec 27, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Dec 27, 2023
@himeshr himeshr moved this from QA Ready to In QA in Avni Product Dec 28, 2023
@himeshr
Copy link
Contributor

himeshr commented Dec 28, 2023

Completed testing the encounter save with time dataType concept, for success and error scenarios.

errorWithInCorrectTimeFormat.txt
successWithCorrectTimeFormat.txt

@himeshr himeshr moved this from In QA to Done in Avni Product Dec 28, 2023
@himeshr
Copy link
Contributor

himeshr commented Dec 28, 2023

Completed following steps as part of deploy:

  • applied data-fix in db to make them null using update sql
  • Moved the flag "lfe_prod" to latest commit done as part of this card on 5.1.0 branch on avni-server
  • didn't need to update this sheet
  • closed the ticket https://avni.freshdesk.com/a/tickets/3342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants