#1280 - run probable query in realm before filtering in memory

avniproject · Jan 30, 2024 · 8336134 · 8336134
1 parent b4b613e
commit 8336134
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/packages/openchs-android/src/service/CallService.js b/packages/openchs-android/src/service/CallService.js
@@ -17,10 +17,9 @@ class CallService extends BaseService {
         const userSettings = this.getService(UserInfoService).getUserSettings();
         const isCallMaskNeeded = _.get(userSettings, "enableCallMasking", false);
 
-        if(isCallMaskNeeded) {
+        if (isCallMaskNeeded) {
             this.connectCall(number, maskedCallResponseCb);
-        }
-        else {
+        } else {
             immediateCallCb();
         }
     }
@@ -33,15 +32,14 @@ class CallService extends BaseService {
             .then(({success, message}) => {
                 if (success) {
                     maskedCallResponseCb("Requested for masked call. Expect a call on your number.");
-                }
-                else {
+                } else {
                     maskedCallResponseCb(`Cannot perform masked call at this time. ${message}`);
                 }
             })
             .catch(error => {
-                maskedCallResponseCb("Cannot perform masked call at this time. (Internet connection unavailable/System error)")
-            }
-    );
+                    maskedCallResponseCb("Cannot perform masked call at this time. (Internet connection unavailable/System error)")
+                }
+            );
     }
 }
 

diff --git a/packages/openchs-android/src/service/IndividualService.js b/packages/openchs-android/src/service/IndividualService.js
@@ -8,7 +8,7 @@ import {
     Privilege,
     ProgramEncounter,
     ProgramEnrolment
-} from "avni-models";
+} from "openchs-models";
 import _ from 'lodash';
 import moment from 'moment';
 import MediaQueueService from "./MediaQueueService";
@@ -22,7 +22,7 @@ import PrivilegeService from "./PrivilegeService";
 import EntityApprovalStatusService from "./EntityApprovalStatusService";
 import GroupSubjectService from "./GroupSubjectService";
 import OrganisationConfigService from './OrganisationConfigService';
-import {getUnderlyingRealmCollection} from "openchs-models";
+import {getUnderlyingRealmCollection, KeyValue} from "openchs-models";
 import RealmQueryService from "./query/RealmQueryService";
 import {DashboardReportFilter} from "../model/DashboardReportFilters";
 
@@ -701,8 +701,12 @@ class IndividualService extends BaseService {
     }
 
     findAllWithMobileNumber(mobileNumber) {
-        return this.getAllNonVoided()
-            .filter(ind => _.toString(ind.getMobileNumber()).slice(-10) === _.toString(mobileNumber).slice(-10));
+        const toMatchMobileNumber = _.toString(mobileNumber).slice(-10);
+        const probableSubjects = this.getAllNonVoided()
+            .filtered(`(observations.concept.keyValues.key = "${KeyValue.PrimaryContactKey}" or observations.concept.keyValues.key = "${KeyValue.ContactNumberKey}") and (observations.valueJSON CONTAINS "${toMatchMobileNumber}")`);
+        return probableSubjects.filter((subject) => {
+            return _.toString(subject.getMobileNumber()).slice(-10) === toMatchMobileNumber;
+        });
     }
 
     getAllBySubjectType(subjectType) {