forked from datahub-project/datahub
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/glue): use resource_links in catalog correctly #1
Closed
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 16f9075 - Browse repository at this point
Copy the full SHA 16f9075View commit details -
fix(ingestion/glue): manage table names from resource_links from near…
…est catalog correctly Changes: If resource links are detected, re-use database names from the current/nearest catalog. Otherwise external resource names are picked out instead of the aliased ones. This will cause an incoherent situation when creating full table names later in DataHub. Refactoring: - database filtering is move to an upper step in `get_databases()` using JMESPath notation - `get_tables_from_database()` signature changed to support database aliases - use an explicit source_config check but it is useless actually (filtering has already been done) Credits to @sl-fredericdalessandro for his preliminary patchset to support LakeFormation in Glue ingestion.
Configuration menu - View commit details
-
Copy full SHA for 14826fe - Browse repository at this point
Copy the full SHA 14826feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a4f87 - Browse repository at this point
Copy the full SHA 24a4f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for c09f13b - Browse repository at this point
Copy the full SHA c09f13bView commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fb6a5b8 - Browse repository at this point
Copy the full SHA fb6a5b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c55511 - Browse repository at this point
Copy the full SHA 6c55511View commit details -
Configuration menu - View commit details
-
Copy full SHA for f21c8bc - Browse repository at this point
Copy the full SHA f21c8bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdb23ac - Browse repository at this point
Copy the full SHA cdb23acView commit details -
Configuration menu - View commit details
-
Copy full SHA for bab8274 - Browse repository at this point
Copy the full SHA bab8274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f6f18c - Browse repository at this point
Copy the full SHA 7f6f18cView commit details -
fix(ingest): cache sql is_profiling_enabled method (datahub-project#1…
…1665) Co-authored-by: Mayuri Nehate <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ba77a9 - Browse repository at this point
Copy the full SHA 7ba77a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7958c4 - Browse repository at this point
Copy the full SHA b7958c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48f4b1a - Browse repository at this point
Copy the full SHA 48f4b1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36c45b5 - Browse repository at this point
Copy the full SHA 36c45b5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.