Skip to content

Commit

Permalink
docs: rephrase some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
aviv-julienjehannet committed Oct 9, 2024
1 parent a227a98 commit 6d156c7
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions metadata-ingestion/src/datahub/ingestion/source/aws/glue.py
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ def get_all_databases(self) -> Iterable[Mapping[str, Any]]:

pattern = "DatabaseList"
if self.source_config.ignore_resource_links:
# exclude records that contain TargetDatabase struct key to ignore resource links
# exclude resource links by using a JMESPath conditional query against the TargetDatabase struct key
pattern += "[?!TargetDatabase]"

for database in paginator_response.search(pattern):
Expand All @@ -701,8 +701,9 @@ def get_tables_from_database(self, database: Mapping[str, Any]) -> Iterable[Dict

for table in paginator_response.search("TableList"):
# if resource links are detected, re-use database names from the current catalog
# otherwise, external names are used instead of aliased ones when creating full table names later
# Note: use an explicit source_config check but it is useless actually (filtering has been done)
# otherwise external resource names are picked out instead of aliased ones
# This will cause an incoherent situation when creating full table names later
# Note: use an explicit source_config check but it is useless actually (filtering has already been done)
if (
not self.source_config.ignore_resource_links
and "TargetDatabase" in database
Expand Down

0 comments on commit 6d156c7

Please sign in to comment.