Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Add reasons #239

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RFC: Add reasons #239

wants to merge 3 commits into from

Conversation

timholy
Copy link
Collaborator

@timholy timholy commented Aug 24, 2021 •
edited
Loading

For JET/SnoopCompile integration, it's likely that the same report
will be generated for many different calls. This PR makes it easy to
distill the collection down to a unique set of causes.

Here's a demo on JuliaIO/ImageIO.jl#38, from inside that package's test directory:

using JET, SnoopCompile
tinf = @snoopi_deep include("runtests.jl")
itrigs = inference_triggers(tinf);
reps = report_callee.(itrigs);     # I'll probably rename this `report`
JET.reasons(reps)

Output:

julia> JET.reasons(reps)
19-element Vector{JET.Reason}:
 │ invalid builtin function call: Base.getfield(t::Tuple{}, i::Int64, $(Expr(:boundscheck)))
tuple.jl:29
 │ variable Base.Cartesian.nargs is not defined: Base.string("number of arguments must be 1 ≤ length(args) ≤ 3, got ", Base.Cartesian.nargs)
cartesian.jl:52
 │ for 1 of union split cases, no matching method found for call signatures (Tuple{typeof(Base._include_from_serialized), String, Bool})): Base._include_from_serialized(path_to_try::String, staledeps::Union{Bool, Vector{Any}})
loading.jl:858
 │ for 1 of union split cases, no matching method found for call signatures (Tuple{typeof(setindex!), Bool, Module, Int64})): Base.setindex!(staledeps::Union{Bool, Vector{Any}}, Core.typeassert(dep::Module, Base.Module)::Module, i::Int64)
loading.jl:853
 │ for 1 of union split cases, no matching method found for call signatures (Tuple{typeof(wait), Bool})): Base.wait(loading::Union{Bool, Condition})
loading.jl:1088
 │ for 1 of union split cases, no matching method found for call signatures (Tuple{typeof(Base.package_slug), Nothing})): Base.package_slug(Base.getproperty(pkg::Base.PkgId, :uuid::Symbol)::Union{Nothing, UUID})
loading.jl:718
 │ variable PNGFiles.fpath is not defined: Core.tuple(PNGFiles.fpath, height::Int64, width::Int64, bit_depth::Int64, color_type::Int64, filters::Int64, compression_level::Int64, compression_strategy::Int64, palette::Nothing, PNGFiles.typeof(image::Matrix{UInt8})::Type{Matrix{UInt8}})
logging.jl:361
 │ variable PNGFiles.fpath is not defined: Core.tuple(PNGFiles.fpath, height::UInt32, width::UInt32, color_type_orig::UInt8, color_type::Union{Int64, UInt8}, bit_depth_orig::UInt8, bit_depth::Union{Int64, UInt8}, num_channels::UInt8, interlace_type::UInt8, gamma::Nothing, Base.getindex(image_gamma::Base.RefValue{Float64})::Float64, screen_gamma::Int64, Base.getindex(intent::Base.RefValue{Int32})::Int32, read_as_paletted::Bool, n_passes::Int32, buffer_eltype::Type, PNGFiles.PNG_HEADER_VERSION_STRING)
logging.jl:361
 │ variable PNGFiles.fpath is not defined: Core.tuple(PNGFiles.fpath, height::Int64, width::Int64, bit_depth::Int64, color_type::Int64, filters::Int64, compression_level::Int64, compression_strategy::Int64, palette::Nothing, PNGFiles.typeof(image::Base.ReinterpretArray{N0f8, 2, UInt8, Matrix{UInt8}, false})::Type{Base.ReinterpretArray{N0f8, 2, UInt8, Matrix{UInt8}, false}})
logging.jl:361
 │ variable PNGFiles.fpath is not defined: Core.tuple(PNGFiles.fpath, height::Int64, width::Int64, bit_depth::Int64, color_type::Int64, filters::Int64, compression_level::Int64, compression_strategy::Int64, palette::Nothing, PNGFiles.typeof(image::Matrix{N0f8})::Type{Matrix{N0f8}})
logging.jl:361
 │ variable PNGFiles.fpath is not defined: Core.tuple(PNGFiles.fpath, height::Int64, width::Int64, bit_depth::Int64, color_type::Int64, filters::Int64, compression_level::Int64, compression_strategy::Int64, palette::Nothing, PNGFiles.typeof(image::Matrix{Gray{N0f8}})::Type{Matrix{Gray{N0f8}}})
logging.jl:361
 │ variable PNGFiles.fpath is not defined: Core.tuple(PNGFiles.fpath, height::Int64, width::Int64, bit_depth::Int64, color_type::Int64, filters::Int64, compression_level::Int64, compression_strategy::Int64, palette::Nothing, PNGFiles.typeof(image::Matrix{RGB{N0f8}})::Type{Matrix{RGB{N0f8}}})
logging.jl:361
 │ type TiffImages.Tag{Union{}} has no field data
/home/tim/.julia/packages/TiffImages/p5czM/src/tags.jl:29
 │ no matching method found for call signature (Tuple{Type{Vector{Int64}}, LinearAlgebra.Factorization}): _::Type{Vector{Int64}}(f::LinearAlgebra.Factorization)
/home/tim/src/julia-master/usr/share/julia/stdlib/v1.8/LinearAlgebra/src/factorization.jl:58
 │ no matching method found for call signature (Tuple{Type{TiffImages.CompressionType}, SubString{String}}): TiffImages.CompressionType(Base.getproperty(t::TiffImages.Tag{String}, :data::Symbol)::SubString{String})
/home/tim/.julia/packages/TiffImages/p5czM/src/tags.jl:128
 │ for 1 of union split cases, no matching method found for call signatures (Tuple{Type{String}, Nothing})): TiffImages.String(Base.getindex(filename::RegexMatch, 1)::Union{Nothing, SubString{String}})
/home/tim/.julia/packages/TiffImages/p5czM/src/utils.jl:35
 │ no matching method found for call signature (Tuple{typeof(isless), LinearAlgebra.Factorization, Int64}): Base.isless(y::LinearAlgebra.Factorization, x::Int64)
operators.jl:492
 │ variable Main.IJulia is not defined: Base.getfield(x::Module, f::Symbol)
Base.jl:35
 │ no matching method found for call signature (Tuple{Type{TiffImages.CompressionType}, Vector{UInt16}}): TiffImages.CompressionType(Base.getproperty(t::TiffImages.Tag{Vector{UInt16}}, :data::Symbol)::Vector{UInt16})
/home/tim/.julia/packages/TiffImages/p5czM/src/tags.jl:128

(nicer in color, of course)

This comes from 255 separate inference triggers, so it's a big reduction. Of course it's possible that it's too big of a reduction, because there may be more that is relevant than just the final frame.

CC @johnnychen94

@timholy
Add reasons
9d3177f 
For JET/SnoopCompile integration, it's likely that the same report
will be generated for many different calls. This makes it easy to
distill the collection down to a unique set of causes.
@timholy
fix loading order
60edba7
@timholy
Copy link
Collaborator Author

timholy commented Aug 24, 2021

We might also want to add a stacktrace(r::Reason) method so you can see the whole thing.

@github-actions
Copy link

github-actions bot commented Aug 24, 2021 •
edited
Loading

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 24 Aug 2021 - 17:09
  • Baseline: 24 Aug 2021 - 17:25
  • Package commits:
  • Target: bce2a6
  • Baseline: f77e53
  • Julia commits:
  • Target: 3d058b
  • Baseline: 3d058b
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.394
Commit 3d058b205e (2021-08-24 12:35 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.2 LTS
 uname: Linux 5.8.0-1039-azure #42~20.04.1-Ubuntu SMP Thu Jul 15 14:11:07 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 5553 s 1 s 348 s 8039 s 0 s
 #2 2593 MHz 5133 s 1 s 345 s 8490 s 0 s
 
 Memory: 6.790924072265625 GB (3384.44140625 MB free)
 Uptime: 1402.47 sec
 Load Avg: 1.01 1.09 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.8.0-DEV.394
Commit 3d058b205e (2021-08-24 12:35 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.2 LTS
 uname: Linux 5.8.0-1039-azure #42~20.04.1-Ubuntu SMP Thu Jul 15 14:11:07 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 10552 s 1 s 583 s 12361 s 0 s
 #2 2593 MHz 9828 s 1 s 576 s 13118 s 0 s
 
 Memory: 6.790924072265625 GB (3339.43359375 MB free)
 Uptime: 2359.64 sec
 Load Avg: 1.0 1.03 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 24 Aug 2021 - 17:9
  • Package commit: bce2a6
  • Julia commit: 3d058b
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 5.568 s (5%) 728 bytes (1%) 19
["cached easy"] 7.790 ms (5%) 728 bytes (1%) 19
["easy"] 1.040 s (5%) 728 bytes (1%) 19
["end to end"] 11.340 s (5%) 146.69 KiB (1%) 263
["first time"] 4.645 s (5%) 920 bytes (1%) 20
["invalidation"] 6.600 s (5%) 1.10 KiB (1%) 31
["package loading"] 290.777 ms (5%) 648 bytes (1%) 19
["top-level first time"] 7.502 s (5%) 1.66 KiB (1%) 20
["top-level"] 7.445 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.394
Commit 3d058b205e (2021-08-24 12:35 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.2 LTS
 uname: Linux 5.8.0-1039-azure #42~20.04.1-Ubuntu SMP Thu Jul 15 14:11:07 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 5553 s 1 s 348 s 8039 s 0 s
 #2 2593 MHz 5133 s 1 s 345 s 8490 s 0 s
 
 Memory: 6.790924072265625 GB (3384.44140625 MB free)
 Uptime: 1402.47 sec
 Load Avg: 1.01 1.09 0.84
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 24 Aug 2021 - 17:25
  • Package commit: f77e53
  • Julia commit: 3d058b
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 5.514 s (5%) 728 bytes (1%) 19
["cached easy"] 7.794 ms (5%) 728 bytes (1%) 19
["easy"] 1.037 s (5%) 728 bytes (1%) 19
["end to end"] 11.128 s (5%) 146.66 KiB (1%) 262
["first time"] 4.635 s (5%) 920 bytes (1%) 20
["invalidation"] 6.438 s (5%) 1.10 KiB (1%) 31
["package loading"] 292.527 ms (5%) 648 bytes (1%) 19
["top-level first time"] 7.544 s (5%) 1.66 KiB (1%) 20
["top-level"] 7.343 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.394
Commit 3d058b205e (2021-08-24 12:35 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.2 LTS
 uname: Linux 5.8.0-1039-azure #42~20.04.1-Ubuntu SMP Thu Jul 15 14:11:07 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 10552 s 1 s 583 s 12361 s 0 s
 #2 2593 MHz 9828 s 1 s 576 s 13118 s 0 s
 
 Memory: 6.790924072265625 GB (3339.43359375 MB free)
 Uptime: 2359.64 sec
 Load Avg: 1.0 1.03 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Stepping: 7
CPU MHz: 2593.904
BogoMIPS: 5187.80
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 2 MiB
L3 cache: 35.8 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft
JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 2 Sep 2021 - 12:58
  • Baseline: 2 Sep 2021 - 13:15
  • Package commits:
  • Target: 4e3b42
  • Baseline: 85aa6b
  • Julia commits:
  • Target: 3aada5
  • Baseline: 3aada5
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["end to end"] 0.99 (5%) 0.08 (1%) ✅
["self analysis"] 1.12 (5%) ❌ 1.00 (1%)
["top-level"] 1.05 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Target

Julia Version 1.8.0-DEV.459
Commit 3aada5982c (2021-09-01 19:46 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.8.0-1040-azure #43~20.04.1-Ubuntu SMP Mon Aug 2 22:06:11 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 5946 s 2 s 347 s 5646 s 0 s
 #2 2593 MHz 5879 s 0 s 358 s 5711 s 0 s
 
 Memory: 6.790924072265625 GB (3424.96875 MB free)
 Uptime: 1200.9 sec
 Load Avg: 1.01 1.07 0.86
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.8.0-DEV.459
Commit 3aada5982c (2021-09-01 19:46 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.8.0-1040-azure #43~20.04.1-Ubuntu SMP Mon Aug 2 22:06:11 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 11486 s 2 s 605 s 10582 s 0 s
 #2 2593 MHz 11235 s 0 s 614 s 10834 s 0 s
 
 Memory: 6.790924072265625 GB (3413.34765625 MB free)
 Uptime: 2276.03 sec
 Load Avg: 1.0 1.02 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 2 Sep 2021 - 12:58
  • Package commit: 4e3b42
  • Julia commit: 3aada5
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 1.141 s (5%) 728 bytes (1%) 19
["cached easy"] 7.274 ms (5%) 728 bytes (1%) 19
["easy"] 913.210 ms (5%) 728 bytes (1%) 19
["end to end"] 9.903 s (5%) 11.19 KiB (1%) 223
["first time"] 3.810 s (5%) 920 bytes (1%) 20
["invalidation"] 2.733 s (5%) 752 bytes (1%) 19
["package loading"] 276.654 ms (5%) 648 bytes (1%) 19
["self analysis"] 20.731 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.788 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.528 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.459
Commit 3aada5982c (2021-09-01 19:46 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.8.0-1040-azure #43~20.04.1-Ubuntu SMP Mon Aug 2 22:06:11 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 5946 s 2 s 347 s 5646 s 0 s
 #2 2593 MHz 5879 s 0 s 358 s 5711 s 0 s
 
 Memory: 6.790924072265625 GB (3424.96875 MB free)
 Uptime: 1200.9 sec
 Load Avg: 1.01 1.07 0.86
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 2 Sep 2021 - 13:15
  • Package commit: 85aa6b
  • Julia commit: 3aada5
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["a bit complex"] 1.135 s (5%) 728 bytes (1%) 19
["cached easy"] 7.188 ms (5%) 728 bytes (1%) 19
["easy"] 907.180 ms (5%) 728 bytes (1%) 19
["end to end"] 9.972 s (5%) 146.36 KiB (1%) 254
["first time"] 3.831 s (5%) 920 bytes (1%) 20
["invalidation"] 2.704 s (5%) 752 bytes (1%) 19
["package loading"] 276.712 ms (5%) 648 bytes (1%) 19
["self analysis"] 18.578 s (5%) 960 bytes (1%) 19
["top-level first time"] 6.776 s (5%) 1.66 KiB (1%) 20
["top-level"] 2.403 s (5%) 1.06 KiB (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • []

Julia versioninfo

Julia Version 1.8.0-DEV.459
Commit 3aada5982c (2021-09-01 19:46 UTC)
Platform Info:
 OS: Linux (x86_64-pc-linux-gnu)
 Ubuntu 20.04.3 LTS
 uname: Linux 5.8.0-1040-azure #43~20.04.1-Ubuntu SMP Mon Aug 2 22:06:11 UTC 2021 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 11486 s 2 s 605 s 10582 s 0 s
 #2 2593 MHz 11235 s 0 s 614 s 10834 s 0 s
 
 Memory: 6.790924072265625 GB (3413.34765625 MB free)
 Uptime: 2276.03 sec
 Load Avg: 1.0 1.02 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 2
On-line CPU(s) list: 0,1
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
NUMA node(s): 1
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Stepping: 7
CPU MHz: 2593.906
BogoMIPS: 5187.81
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB
L1i cache: 64 KiB
L2 cache: 2 MiB
L3 cache: 35.8 MiB
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

aviatesk
aviatesk approved these changes Aug 26, 2021
View reviewed changes
Copy link
Owner

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it seems more reasonable to aggregate reports based on the "final" frame of reports for this case.
When analyzing user-level script, it might be better to focus on the "entry" frame (usages) rather than the final frame (definitions), because it's more likely that we're interested in wrong usages of package code.
But as for SnoopCompile integration, our main interest is package development, and then it's more appropriate to see definitions.

FWIW, incoming VSCode integration, I want to setup some interface to switch this behavior, and this "reason" interface may also want to use it. But anyway. I think this can be merged as is for now.

@timholy
Copy link
Collaborator Author

timholy commented Aug 26, 2021

👍 Before I hit merge, I might think about the name a bit more (it was a bit tongue-in-cheek, though it's not dreadful either) and make sure it actually works in practice to fix some issues. For example, I have a sneaking suspicion that we may want to aggregate using the bottom frame and one just above it.

@aviatesk
Copy link
Owner

aviatesk commented Sep 2, 2021

I made a significant refactor recently. I will try to update this branch as well as SnoopCompile side code later.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021 •
edited
Loading

Codecov Report

Merging #239 (e233531) into master (85aa6be) will decrease coverage by 0.77%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   87.67%   86.90%   -0.78%     
==========================================
  Files           9       10       +1     
  Lines        2021     2039      +18     
==========================================
  Hits         1772     1772              
- Misses        249      267      +18
Impacted Files Coverage Δ
src/JET.jl 67.38% <ø> (ø)
src/abstractinterpret/inferenceerrorreport.jl 87.76% <ø> (ø)
src/ui/reasons.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85aa6be...e233531. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timholy @aviatesk @codecov-commenter