Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Generalize control flow analysis for infinite iteration #199

Closed
wants to merge 0 commits into from

Conversation

samarthkishor
Copy link

@samarthkishor samarthkishor commented May 10, 2021

Builds on the work in #186

  • fixes the issue where sum(a for a in NeverTerminate(::Int))
    did not report an error
  • refactors iteration termination check into a separate function
  • adds another function to find iteration info for a BasicBlock

@aviatesk
Copy link
Owner

Thanks ! Don't you mind if I push a commit to this branch ? (e.g. resolve conflict or such)

@samarthkishor
Copy link
Author

Thanks ! Don't you mind if I push a commit to this branch ? (e.g. resolve conflict or such)

Sure, go ahead!

@aviatesk
Copy link
Owner

Sorry I couldn't manage to update this branch as I expected, maybe because this branch has the same base name as the target (i.e. iteration).
I opened yet another PR to take your changes in: #200

I will review the changes there, and if you want to make changes to the branch, please make another PR on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants