Skip to content

Commit

Permalink
Add tests for Defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
averevki committed Jun 18, 2024
1 parent 2f17e45 commit f99a8cd
Show file tree
Hide file tree
Showing 3 changed files with 82 additions and 0 deletions.
Empty file.
45 changes: 45 additions & 0 deletions testsuite/tests/kuadrant/defaults/test_basic.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
"""Test basic enforcement of the rules inside the 'defaults' block of the AuthPolicy and RateLimitPolicy"""

import pytest

from testsuite.httpx.auth import HttpxOidcClientAuth
from testsuite.policy.rate_limit_policy import Limit

pytestmark = [pytest.mark.kuadrant_only, pytest.mark.limitador]

LIMIT = Limit(3, 5)


@pytest.fixture(scope="module")
def authorization(authorization, oidc_provider):
"""Add oidc identity to defaults block of AuthPolicy"""
authorization.identity.add_oidc("default", oidc_provider.well_known["issuer"], defaults=True)
return authorization


@pytest.fixture(scope="module")
def auth(oidc_provider):
"""Returns Authentication object for HTTPX"""
return HttpxOidcClientAuth(oidc_provider.get_token, "authorization")


@pytest.fixture(scope="module")
def rate_limit(rate_limit):
"""Add basic requests limit to defaults block of RateLimitPolicy"""
rate_limit.add_limit("basic", [LIMIT], defaults=True)
return rate_limit


def test_basic(route, authorization, rate_limit, client, auth):
"""Test if rules inside defaults block are enforced like any other normal rule"""
route.refresh()
assert route.is_affected_by(authorization)

response = client.get("/get")
assert response.status_code == 401 # assert that AuthPolicy is enforced

assert route.is_affected_by(rate_limit)

responses = client.get_many("/get", LIMIT.limit, auth=auth)
responses.assert_all(status_code=200)
assert client.get("/get", auth=auth).status_code == 429 # assert that RateLimitPolicy is enforced
37 changes: 37 additions & 0 deletions testsuite/tests/kuadrant/defaults/test_rules_exclusivity.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
"""Test mutual exclusivity of defaults block and implicit defaults"""

import pytest
from openshift_client import OpenShiftPythonException

from testsuite.policy.rate_limit_policy import Limit

pytestmark = [pytest.mark.kuadrant_only, pytest.mark.limitador]


@pytest.fixture(scope="module")
def authorization(authorization, oidc_provider):
"""Create AuthPolicy with basic oidc rules inside and outside defaults block"""
authorization.identity.add_oidc("inside-defaults", oidc_provider.well_known["issuer"], defaults=True)
authorization.identity.add_oidc("outside-defaults", oidc_provider.well_known["issuer"])
return authorization


@pytest.fixture(scope="module")
def rate_limit(rate_limit):
"""Add basic rate limiting rules inside and outside defaults block"""
rate_limit.add_limit("inside-defaults", [Limit(2, 5)], defaults=True)
rate_limit.add_limit("outside-defaults", [Limit(2, 5)])
return rate_limit


@pytest.fixture(scope="module")
def commit():
"""We need to try to commit objects during the actual test"""
return None


def test_rules_exclusivity(authorization, rate_limit):
"""Test that server will reject object with implicit and explicit defaults defined simultaneously"""
for component in [authorization, rate_limit]:
with pytest.raises(OpenShiftPythonException, match="Implicit and explicit defaults are mutually exclusive"):
component.commit()

0 comments on commit f99a8cd

Please sign in to comment.