Remove not existing readOnly field from the SecretVolume

averevki · Jun 19, 2024 · 0b05fb4 · 0b05fb4
1 parent ad5fa9a
commit 0b05fb4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/testsuite/gateway/envoy/tls.py b/testsuite/gateway/envoy/tls.py
@@ -70,9 +70,9 @@ def config(self):
 
     def create_deployment(self) -> Deployment:
         deployment = super().create_deployment()
-        deployment.add_volume(SecretVolume(secret_name=self.authorino_ca_secret, name="authorino-ca", readOnly=True))
-        deployment.add_volume(SecretVolume(secret_name=self.backend_ca_secret, name="envoy-ca", readOnly=True))
-        deployment.add_volume(SecretVolume(secret_name=self.envoy_cert_secret, name="envoy-cert", readOnly=True))
+        deployment.add_volume(SecretVolume(secret_name=self.authorino_ca_secret, name="authorino-ca"))
+        deployment.add_volume(SecretVolume(secret_name=self.backend_ca_secret, name="envoy-ca"))
+        deployment.add_volume(SecretVolume(secret_name=self.envoy_cert_secret, name="envoy-cert"))
 
         deployment.add_mount(VolumeMount(mountPath="/etc/ssl/certs/authorino-ca", name="authorino-ca"))
         deployment.add_mount(VolumeMount(mountPath="/etc/ssl/certs/envoy-ca", name="envoy-ca"))

diff --git a/testsuite/openshift/deployment.py b/testsuite/openshift/deployment.py
@@ -64,11 +64,10 @@ class SecretVolume:
 
     secret_name: str
     name: str
-    readOnly: bool = True
 
     def asdict(self):
         """Custom asdict because of needing to put location as parent dict key for inner dict"""
-        return {"secret": {"readOnly": self.readOnly, "secretName": self.secret_name}, "name": self.name}
+        return {"secret": {"secretName": self.secret_name}, "name": self.name}
 
 
 Volume = SecretVolume | ConfigMapVolume