This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3 from avans-night-byte/feature/PR-template
✨ Add simple PR Template
- Loading branch information
Showing
1 changed file
with
32 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Merge Request Template | ||
|
||
## Description | ||
### What's new? | ||
... | ||
|
||
### What has changed? | ||
... | ||
|
||
### Extra information? | ||
... | ||
|
||
## Definition of Done | ||
### Code | ||
- [ ] Code voldoet aan alle genoemde eisen in de code conventions. | ||
- [ ] Code komt sterk overeen met gamedesign (User Story #1). | ||
- [ ] Code komt overeen met het technisch design, bij nodige afwijking wordt het diagram geupdate en de update gecommuniceerd met het hele team. | ||
- [ ] Code gedocumenteerd (comments). | ||
- [ ] Code gecontroleerd op (stilistische) fouten. | ||
- [ ] Unit tests geschreven en geslaagd voor nieuwe code. | ||
- [x] ~~Code is reviewed door minimaal één ander teamlid. Voor complexe danwel grote PR door minimaal 2 teamleden.~~ PR gerelateerd. | ||
- [ ] Aan alle in de story benoemde acceptatie criteria is voldaan. | ||
|
||
### Documentatie | ||
- [ ] Github wiki aangepast. | ||
|
||
### Testen | ||
- [ ] Alle (nieuwe) code runt lokaal op het systeem van de developer. | ||
- [ ] Alle gevonden bugs zijn onderkend en indien deze niet op korte termijn opgelost kunnen worden, als nieuw item opgenomen in de backlog. | ||
|
||
### Overige | ||
- [ ] User story in Taiga staat op Testing, wanneer getest op Done. |