Separate display date into 'Creation date' and 'Publication date' #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Oct 7, 2024
masaball
commented
Oct 8, 2024
| @@ -66,3 +66,7 @@ img.no-icon { | |||
| .page-item span.page-link { | |||
| color: $dark !important; | |||
| } | |||
|
|
|||
| .blacklight-date_issued_ssi.col-sm-3 { | |||
| white-space: nowrap; | |||
There was a problem hiding this comment.
"Publication date" was too long to display on a single line on the search page with the default css, so override to keep it inline.
masaball
force-pushed
the
separate_dates
branch
from
0ad9326
to
7f2b948
Compare
cjcolvar
reviewed
Oct 8, 2024
Comment on lines
+116
to
+117
| config.add_index_field 'date_issued_ssi', label: 'Publication date' | ||
| config.add_index_field 'date_created_ssi', label: 'Creation date' |
There was a problem hiding this comment.
Good catch! I forgot about the combined dates on search results. This probably also comes up in collection landing page search results.
@joncameron Which dates do you think should be displayed on search results?
cjcolvar
reviewed
Oct 8, 2024
Co-authored-by: Chris Colvard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #6050