Date issued is no longer a required field #6047
Conversation
| result = media_object.date_issued | ||
| result += " (Creation date: #{media_object.date_created})" if media_object.date_created.present? |
There was a problem hiding this comment.
I think this does need to be changed. If someone provides a creation date but not an issued date then this method will raise an exception as written. That may be edge case enough (especially since it is new behavior) to not block this PR, but we should at least create a follow-up ticket to rework this.
There was a problem hiding this comment.
@joncameron What do you think about un-combining the display date so it is two separate metadata values in the IIIF manifest?
"Publication date: #{media_object.date_issued}" if media_object.date_issued.present?
"Creation date: #{media_object.date_created}" if media_object.date_created.present?
There was a problem hiding this comment.
I would love it—that makes a lot more sense and especially with this change. I created #6050 for changing the manifest generation to separate the date fields.
There was a problem hiding this comment.
Since a new issue has been created, I'll go ahead and approve this PR 👍
Resolves #6021