Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VAT Transport value when config value is null #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffjim
Copy link

@jeffjim jeffjim commented Feb 10, 2023

This fixes an exception that occurs when the VAT transport configuration was never given any values and returns null. It then assigns it to an empty string which later gets json unserialized and throws an exception.

  1. ClassyLlama\AvaTax\Framework\Interaction function getTaxRequestForSalesObject($object) line 708 retrieves the VAT transport config value.
  2. Same function, line 710 attempts to unserialize an empty string which throws an exception because of a "Syntax error".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant