add standalone dbs and configs #1354
Open
+209
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
reviewed
Oct 14, 2024
darioush
previously approved these changes
Oct 15, 2024
darioush
reviewed
Oct 15, 2024
darioush
reviewed
Oct 16, 2024
| // initialize the atomic memory | ||
| atomicMemory := atomic.NewMemory(prefixdb.New([]byte{0}, baseDB)) | ||
| atomicMemory := atomic.NewMemory(prefixdb.New([]byte{0}, memdb.New())) |
There was a problem hiding this comment.
nit: this file could be reverted if preferred
darioush
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
plugin/evmpackage to support standalone databases, update configurations, and enhance testing. The most important changes include adding new database-related configurations, updating theVMstruct and initialization process, and modifying tests to accommodate the newskipStandaloneDBflag.Database Configuration Enhancements:
plugin/evm/config.go: Added new database-related configurations includingUseStandaloneDatabase,DatabaseConfigContent,DatabaseConfigFile,DatabaseType,DatabasePath, andDatabaseReadOnly. Also added a new typePBoolto handle optional boolean values. [1] [2] [3] [4]VM Struct and Initialization Updates:
plugin/evm/vm.go: Updated theVMstruct to include askipStandaloneDBflag andchainAlias. Modified theInitializemethod to handle standalone database initialization and metrics setup. Added new methodsuseStandaloneDatabase,getDatabaseConfig,initializeDBs, andcreateDatabaseto support the new database configurations. [1] [2] [3] [4] [5]By default VM uses a standalone database if there is no accepted block in AvalancheGo's provided database.
use-standalone-databaseis nil by default, and can override the default behavior by takingfalse/trueas value.Test Updates:
plugin/evm/block_test.go,plugin/evm/syncervm_test.go,plugin/evm/tx_gossip_test.go,plugin/evm/vm_test.go: Updated various test cases to set theskipStandaloneDBflag totrueto ensure tests run with the intended database configuration. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]These changes enhance the flexibility and configurability of the EVM plugin, allowing for more robust database management and testing.
How this was tested
Tested with DFK
How is this documented
Need to document in docs repo.
Some metrics running the LevelDB in DFK testnet with two similar spec machines: