-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support iterators and views in grpc in firewood #533
Draft
rkuris
wants to merge
24
commits into
main
Choose a base branch
from
rkuris/implement-merkle-grpc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Feb 15, 2024
-
Dan Laine committed
Feb 15, 2024 Configuration menu - View commit details
-
Copy full SHA for bee6c15 - Browse repository at this point
Copy the full SHA bee6c15View commit details -
Dan Laine committed
Feb 15, 2024 Configuration menu - View commit details
-
Copy full SHA for a21c255 - Browse repository at this point
Copy the full SHA a21c255View commit details -
Merge branch 'main' into danlaine/view-server-proto
Dan Laine authoredFeb 15, 2024 Configuration menu - View commit details
-
Copy full SHA for e29e5fa - Browse repository at this point
Copy the full SHA e29e5faView commit details
Commits on Feb 16, 2024
-
Dan Laine committed
Feb 16, 2024 Configuration menu - View commit details
-
Copy full SHA for 3ebbb71 - Browse repository at this point
Copy the full SHA 3ebbb71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c93966 - Browse repository at this point
Copy the full SHA 8c93966View commit details -
Still todo!() in all implementations Fixed up build.rs so that it only rebuilds the tonic things when the specs change, which is rare, speeding up incremental builds.
Configuration menu - View commit details
-
Copy full SHA for 6d2e47c - Browse repository at this point
Copy the full SHA 6d2e47cView commit details -
Made it a bit easier to add more proto files, and also report to cargo that these are the only files that cause the build.rs to run again
Configuration menu - View commit details
-
Copy full SHA for 7d3046b - Browse repository at this point
Copy the full SHA 7d3046bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f40f0d - Browse repository at this point
Copy the full SHA 1f40f0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd86e5c - Browse repository at this point
Copy the full SHA fd86e5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f517585 - Browse repository at this point
Copy the full SHA f517585View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6320c0 - Browse repository at this point
Copy the full SHA f6320c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1131c07 - Browse repository at this point
Copy the full SHA 1131c07View commit details
Commits on Feb 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for df9b19b - Browse repository at this point
Copy the full SHA df9b19bView commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ddadd4d - Browse repository at this point
Copy the full SHA ddadd4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d44238 - Browse repository at this point
Copy the full SHA 6d44238View commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e779124 - Browse repository at this point
Copy the full SHA e779124View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6399d5f - Browse repository at this point
Copy the full SHA 6399d5fView commit details -
Use CommitError from the proto
These have a built-in as_str_name method we can utilize. Unfortunately, the proto system's error wants an implementation for Into<String>, so I implemented From<CommitError> for String.
Configuration menu - View commit details
-
Copy full SHA for 12d74b1 - Browse repository at this point
Copy the full SHA 12d74b1View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6706e63 - Browse repository at this point
Copy the full SHA 6706e63View commit details
Commits on Feb 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for abd6bac - Browse repository at this point
Copy the full SHA abd6bacView commit details
Commits on Feb 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7d5ea3f - Browse repository at this point
Copy the full SHA 7d5ea3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe19314 - Browse repository at this point
Copy the full SHA fe19314View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4255e5b - Browse repository at this point
Copy the full SHA 4255e5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6236f2a - Browse repository at this point
Copy the full SHA 6236f2aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.