Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node/config.go: remove unused options #304

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

darioush
Copy link
Collaborator

@darioush darioush commented Aug 17, 2023

Why this should be merged

We don't use these options

How this works

Removes dead code

How this was tested

CI

@darioush darioush changed the title node/config.go: remove unused graphql options node/config.go: remove unused options Aug 17, 2023
@darioush darioush marked this pull request as ready for review August 18, 2023 17:24
@aaronbuchwald aaronbuchwald merged commit 5cd24c3 into master Aug 23, 2023
7 of 8 checks passed
@aaronbuchwald aaronbuchwald deleted the remove-graphql-config branch August 23, 2023 15:48
joshua-kim added a commit that referenced this pull request Aug 29, 2023
commit 4ef26a0
Author: Darioush Jalali <[email protected]>
Date:   Mon Aug 28 06:38:44 2023 -0700

    bump go version in dockerfile (#311)

commit 505a6ab
Author: aaronbuchwald <[email protected]>
Date:   Fri Aug 25 15:43:09 2023 -0400

    core/state/snapshot: increase batch size during diffToDisk (#309)

commit cca3e00
Author: marun <[email protected]>
Date:   Fri Aug 25 09:44:42 2023 -0700

    Bump golang version to 1.19.12 for CI (#306)

    * Bump golang version to 1.19.12 for CI

    Also bump targeted version of avalanchego to the v1.10.8 (which also
    uses golang 1.19.12).

    * fixup: Update go-version specification for consistency with other repos

commit 42ba830
Author: Darioush Jalali <[email protected]>
Date:   Fri Aug 25 09:44:12 2023 -0700

    add upstream test: TestClientBatchRequest_len (#307)

commit 08e2b6e
Author: Stephen Buttolph <[email protected]>
Date:   Wed Aug 23 18:09:51 2023 -0400

    Update avalanchego dependency to v1.10.9-rc.4 (#308)

commit 5cd24c3
Author: Darioush Jalali <[email protected]>
Date:   Wed Aug 23 08:48:01 2023 -0700

    node/config.go: remove unused options (#304)

    * node/config.go: remove unused graphql options

    * remove more unused config

commit 8ea8b18
Author: aaronbuchwald <[email protected]>
Date:   Tue Aug 15 11:18:29 2023 -0400

    Add security file based on AvalancheGo (#303)

commit 00214b1
Author: Stephen Buttolph <[email protected]>
Date:   Mon Aug 14 14:58:07 2023 -0400

    Update AVAX client implementation and interface to align types (#301)

commit 5666553
Author: Ceyhun Onur <[email protected]>
Date:   Mon Aug 14 21:38:04 2023 +0300

    renamed flags (#298)

    * renamed flags

    * rename admin api flags

    * add deprecation

commit e7645fa
Author: Ikko Eltociear Ashimine <[email protected]>
Date:   Thu Aug 10 01:21:44 2023 +0900

    Fix typo in sync/README.md (#296)
joshua-kim added a commit that referenced this pull request Aug 30, 2023
commit 4ef26a0
Author: Darioush Jalali <[email protected]>
Date:   Mon Aug 28 06:38:44 2023 -0700

    bump go version in dockerfile (#311)

commit 505a6ab
Author: aaronbuchwald <[email protected]>
Date:   Fri Aug 25 15:43:09 2023 -0400

    core/state/snapshot: increase batch size during diffToDisk (#309)

commit cca3e00
Author: marun <[email protected]>
Date:   Fri Aug 25 09:44:42 2023 -0700

    Bump golang version to 1.19.12 for CI (#306)

    * Bump golang version to 1.19.12 for CI

    Also bump targeted version of avalanchego to the v1.10.8 (which also
    uses golang 1.19.12).

    * fixup: Update go-version specification for consistency with other repos

commit 42ba830
Author: Darioush Jalali <[email protected]>
Date:   Fri Aug 25 09:44:12 2023 -0700

    add upstream test: TestClientBatchRequest_len (#307)

commit 08e2b6e
Author: Stephen Buttolph <[email protected]>
Date:   Wed Aug 23 18:09:51 2023 -0400

    Update avalanchego dependency to v1.10.9-rc.4 (#308)

commit 5cd24c3
Author: Darioush Jalali <[email protected]>
Date:   Wed Aug 23 08:48:01 2023 -0700

    node/config.go: remove unused options (#304)

    * node/config.go: remove unused graphql options

    * remove more unused config

commit 8ea8b18
Author: aaronbuchwald <[email protected]>
Date:   Tue Aug 15 11:18:29 2023 -0400

    Add security file based on AvalancheGo (#303)

commit 00214b1
Author: Stephen Buttolph <[email protected]>
Date:   Mon Aug 14 14:58:07 2023 -0400

    Update AVAX client implementation and interface to align types (#301)

commit 5666553
Author: Ceyhun Onur <[email protected]>
Date:   Mon Aug 14 21:38:04 2023 +0300

    renamed flags (#298)

    * renamed flags

    * rename admin api flags

    * add deprecation

commit e7645fa
Author: Ikko Eltociear Ashimine <[email protected]>
Date:   Thu Aug 10 01:21:44 2023 +0900

    Fix typo in sync/README.md (#296)
joshua-kim added a commit to joshua-kim/coreth that referenced this pull request Aug 30, 2023
commit 3f5dc8a
Author: marun <[email protected]>
Date:   Tue Aug 29 10:17:05 2023 -0700

    e2e: Add avalanchego e2e job (ava-labs#305)

    * e2e: Add avalanchego e2e job

    * fixup: Use currently supported golang version

    * fixup: Enable configurable avalanchego clone path

commit 4ef26a0
Author: Darioush Jalali <[email protected]>
Date:   Mon Aug 28 06:38:44 2023 -0700

    bump go version in dockerfile (ava-labs#311)

commit 505a6ab
Author: aaronbuchwald <[email protected]>
Date:   Fri Aug 25 15:43:09 2023 -0400

    core/state/snapshot: increase batch size during diffToDisk (ava-labs#309)

commit cca3e00
Author: marun <[email protected]>
Date:   Fri Aug 25 09:44:42 2023 -0700

    Bump golang version to 1.19.12 for CI (ava-labs#306)

    * Bump golang version to 1.19.12 for CI

    Also bump targeted version of avalanchego to the v1.10.8 (which also
    uses golang 1.19.12).

    * fixup: Update go-version specification for consistency with other repos

commit 42ba830
Author: Darioush Jalali <[email protected]>
Date:   Fri Aug 25 09:44:12 2023 -0700

    add upstream test: TestClientBatchRequest_len (ava-labs#307)

commit 08e2b6e
Author: Stephen Buttolph <[email protected]>
Date:   Wed Aug 23 18:09:51 2023 -0400

    Update avalanchego dependency to v1.10.9-rc.4 (ava-labs#308)

commit 5cd24c3
Author: Darioush Jalali <[email protected]>
Date:   Wed Aug 23 08:48:01 2023 -0700

    node/config.go: remove unused options (ava-labs#304)

    * node/config.go: remove unused graphql options

    * remove more unused config

commit 8ea8b18
Author: aaronbuchwald <[email protected]>
Date:   Tue Aug 15 11:18:29 2023 -0400

    Add security file based on AvalancheGo (ava-labs#303)

commit 00214b1
Author: Stephen Buttolph <[email protected]>
Date:   Mon Aug 14 14:58:07 2023 -0400

    Update AVAX client implementation and interface to align types (ava-labs#301)

commit 5666553
Author: Ceyhun Onur <[email protected]>
Date:   Mon Aug 14 21:38:04 2023 +0300

    renamed flags (ava-labs#298)

    * renamed flags

    * rename admin api flags

    * add deprecation

commit e7645fa
Author: Ikko Eltociear Ashimine <[email protected]>
Date:   Thu Aug 10 01:21:44 2023 +0900

    Fix typo in sync/README.md (ava-labs#296)
darioush pushed a commit that referenced this pull request Apr 25, 2024
* implementing cross-chain app handlers

* nits

Co-authored-by: Ceyhun Onur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants