feat: CP-9474 import private key activate account, design fixes #89
+18
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
requested changes
Nov 27, 2024
Comment on lines
66
to
67
| color: fontColor, | ||
| backgroundColor: isActive ? 'grey.400' : 'default', |
There was a problem hiding this comment.
These 'default' values for color and backgroundColor don't work:
Did you mean to use currentColor for the text?
For the background, if you intended to use the theme.palette.background.default from K2, the value should be background.default instead.
bferenc
approved these changes
Nov 27, 2024
meeh0w
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to make the latest imported account to be the active account.
Changes
After the import phase we select the account. There are few design fixes in addition.
Testing
Go to accounts page -> import an account
Screenshots:
Screen.Recording.2024-11-13.at.14.51.37.mov
Checklist for the author
Tick each of them when done or if not applicable.