Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-9466] fix x-chain history amounts #88

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

bferenc
Copy link
Contributor

@bferenc bferenc commented Nov 9, 2024

Description

Both the transaction fee and spend / receive amount values were wrongly in the X-chain's activity list.

Changes

Fixed X-chain amount calculation in vm-modules

Testing

  • Check if your X-chain activity list contains the correct amounts for different tx types (BaseTx, Import and Export)
  • Do a quick X/P transaction signing check because of the AJS version bump

Screenshots:

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

gergelylovas
gergelylovas previously approved these changes Nov 11, 2024
Copy link
Contributor

@gergelylovas gergelylovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X-chain Base transactions tested as well. Works as expected, nice work!

@bferenc bferenc merged commit f8db382 into main Nov 11, 2024
5 of 6 checks passed
@bferenc bferenc deleted the fix/CP-9466-x-chain-history-amounts branch November 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants