Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: approval screens for the new Etna tx types #87

Merged
merged 18 commits into from
Nov 21, 2024
Merged

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Nov 8, 2024

Description

Related PRs:

Changes

  • Adds approval screens for new Etna transactions

Testing

  • With the playground app PR listed above. If AvalancheJS PR is not merged yet, you'll need to link it locally.
    • The code in the playground includes comments on how to obtain the required parameters
    • New transactions are: ConvertSubnetToL1, RegisterL1Validator, SetL1ValidatorWeight, IncreaseL1ValidatorBalance, DisableL1Validator, but ideally we should test everything.
    • According to the AvaCloud team, we don't need to support multi-sig on the new transactions just yet -- this part is not tested by me.

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w changed the title [wip] feat: new etna tx types feat: approval screens for the new Etna tx types Nov 21, 2024
@meeh0w meeh0w removed the DO NOT MERGE This PR is not meant to be merged in its current state label Nov 21, 2024
@meeh0w meeh0w marked this pull request as ready for review November 21, 2024 19:06
Base automatically changed from feat/pchain-dynamic-fees to main November 21, 2024 20:36
@meeh0w meeh0w merged commit 90dbf7d into main Nov 21, 2024
6 checks passed
@meeh0w meeh0w deleted the feat/new-etna-tx-types branch November 21, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants