remove state commit on disconnect #3385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
commented
Sep 13, 2024
Comment on lines
-490
to
-477
| if err := vm.state.Commit(); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
if we want to we can move this to SetPreference (or some periodic go routine like mempool pruning etc). I'd imagine block acceptance should be sufficient enough though.
There was a problem hiding this comment.
Another thing you can do is to check when was the last time you committed the disconnected nodes. If it's less than, say, 1 second ago, then not commit.
There was a problem hiding this comment.
yea good idea we could do that instead. but I slightly think that state should be commited with respect to chain progress.
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Committing state adds an overhead on peer disconnects
How this works
Removes state commit from disconnect. Block acceptance/Shutdown should be sufficient for writing disk to the state.
How this was tested
existing UTs should cover this